Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: tools/presubmit.py

Issue 1327523003: [presubmit] Fix whitespace/empty_loop_body linter violations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/allocation-tracker.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 -build/include_what_you_use 61 -build/include_what_you_use
62 -build/namespaces 62 -build/namespaces
63 -readability/check 63 -readability/check
64 -readability/inheritance 64 -readability/inheritance
65 -readability/namespace 65 -readability/namespace
66 -readability/nolint 66 -readability/nolint
67 +readability/streams 67 +readability/streams
68 -runtime/references 68 -runtime/references
69 -runtime/threadsafe_fn 69 -runtime/threadsafe_fn
70 -whitespace/semicolon 70 -whitespace/semicolon
71 -whitespace/empty_loop_body
72 """.split() 71 """.split()
73 72
74 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing') 73 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing')
75 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n") 74 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n")
76 75
77 def CppLintWorker(command): 76 def CppLintWorker(command):
78 try: 77 try:
79 process = subprocess.Popen(command, stderr=subprocess.PIPE) 78 process = subprocess.Popen(command, stderr=subprocess.PIPE)
80 process.wait() 79 process.wait()
81 out_lines = "" 80 out_lines = ""
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 success = SourceProcessor().Run(workspace) and success 459 success = SourceProcessor().Run(workspace) and success
461 success = CheckExternalReferenceRegistration(workspace) and success 460 success = CheckExternalReferenceRegistration(workspace) and success
462 if success: 461 if success:
463 return 0 462 return 0
464 else: 463 else:
465 return 1 464 return 1
466 465
467 466
468 if __name__ == '__main__': 467 if __name__ == '__main__':
469 sys.exit(Main()) 468 sys.exit(Main())
OLDNEW
« no previous file with comments | « src/allocation-tracker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698