Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1327503002: [DevTools] Set correct overlay size for scaled page. (Closed)

Created:
5 years, 3 months ago by dgozman
Modified:
5 years, 3 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Set correct overlay size for scaled page. Overlay was sized to visible size, but it is not scaled together with the page. Therefore, the correct size is equal to viewport size. BUG=508136 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/PageOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dgozman
Take a look please.
5 years, 3 months ago (2015-08-31 21:28:28 UTC) #2
sergeyv
lgtm
5 years, 3 months ago (2015-08-31 23:30:14 UTC) #3
dgozman
ping
5 years, 3 months ago (2015-09-01 17:58:22 UTC) #4
pfeldman
lgtm
5 years, 3 months ago (2015-09-01 19:29:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327503002/1
5 years, 3 months ago (2015-09-01 19:29:59 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 21:46:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201573

Powered by Google App Engine
This is Rietveld 408576698