Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: Source/core/paint/DeprecatedPaintLayerStackingNode.h

Issue 1327483003: Add documentation to 2 DeprecatedPaintLayer objects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/DeprecatedPaintLayerStackingNode.h
diff --git a/Source/core/paint/DeprecatedPaintLayerStackingNode.h b/Source/core/paint/DeprecatedPaintLayerStackingNode.h
index d4b0150ca1e833351e9e4222832cacb55e4e7a24..5e7220e364d5eea095acd1cdc266b5221d8ecc6d 100644
--- a/Source/core/paint/DeprecatedPaintLayerStackingNode.h
+++ b/Source/core/paint/DeprecatedPaintLayerStackingNode.h
@@ -58,6 +58,28 @@ class DeprecatedPaintLayerCompositor;
class ComputedStyle;
class LayoutBoxModelObject;
+// DeprecatedPaintLayerStackingNode represents anything that is treated as a
+// stacking context.
+//
+// Stacking contexts are the basis for the CSS painting algorithm. The paint
+// order is determined by walking stacking contexts (or elements treated like a
+// stacking context like positioned objects or floats) in an order defined by
+// ‘z-index’. This walk is interleaved with content that is not a stacking.
+// context. See CSS 2.1 appendix e for the actual algorithm
mstensho (USE GERRIT) 2015/09/01 18:59:06 Might want to capitalize that "e".
Julien - ping for review 2015/09/03 14:25:54 D-O-N-E!
+// http://www.w3.org/TR/CSS21/zindex.html
+// See also DeprecatedPaintLayerPainter (in particular paintLayerContents) for
+// our implementation of the walk.
+//
+// Stacking contexts form a subtree over the layout tree. Ideally we would want
+// this class to be a node in this tree but there are potential issues with
mstensho (USE GERRIT) 2015/09/01 18:59:06 "objects of this class to be nodes in this tree"?
Julien - ping for review 2015/09/03 14:25:54 sgtm.
+// stale pointers so we rely on DeprecatedPaintLayer's tree structure.
+//
+// This class's purpose is to cache the z-order lists for painting and
eae 2015/09/01 18:08:59 They're used to represent and not just cache the s
Julien - ping for review 2015/09/03 14:25:54 Good catch. Amended the description of the class t
+// hit-testing.
+//
+// To implement any zorder list iterations, use
mstensho (USE GERRIT) 2015/09/01 18:59:06 "z-order"
Julien - ping for review 2015/09/03 14:25:54 changed.
+// DeprecatedPaintLayerStackingNodeIterator and
+// DeprecatedPaintLayerStackingNodeReverseIterator.
class CORE_EXPORT DeprecatedPaintLayerStackingNode {
WTF_MAKE_FAST_ALLOCATED(DeprecatedPaintLayerStackingNode);
WTF_MAKE_NONCOPYABLE(DeprecatedPaintLayerStackingNode);

Powered by Google App Engine
This is Rietveld 408576698