Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 132743006: Initialize AppListItem::has_shadow_ to avoid uninitialized reads. (Closed)

Created:
6 years, 10 months ago by Derek Bruening
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Initialize AppListItem::has_shadow_ to avoid uninitialized reads. BUG=338739 R=koz@chromium.org TEST=unit_tests:AppListModelPicklerUnitTest.OneItem Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247620

Patch Set 1 #

Patch Set 2 : bogus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
chrome/browser/extensions/extension_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Derek Bruening
6 years, 10 months ago (2014-01-28 17:34:57 UTC) #1
koz (OOO until 15th September)
lgtm, thanks!
6 years, 10 months ago (2014-01-29 00:12:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruening@chromium.org/132743006/1
6 years, 10 months ago (2014-01-29 01:13:35 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 05:11:32 UTC) #4
Message was sent while issue was closed.
Change committed as 247620

Powered by Google App Engine
This is Rietveld 408576698