Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1327243002: Revert of Add support for converting I420 software frames into NV12 hardware frames (Closed)

Created:
5 years, 3 months ago by tommi (sloooow) - chröme
Modified:
5 years, 2 months ago
CC:
cc-bugs_chromium.org, ccameron, chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@biplanar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for converting I420 software frames into NV12 hardware frames (patchset #6 id:140001 of https://codereview.chromium.org/1307853003/ ) Reason for revert: We suspect this CL caused a WebRTC browser test to start failing. The failures are consistent and started here: https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/21330 Original issue's description: > Add support for converting I420 software frames into NV12 hardware frames > > Enhance MaybeCreateHardwareFrame() to be able to create a NV12 hardware > frame backed by a YUV_420_BIPLANAR GpuMemoryBuffer. > > This code path is not enabled yet. > > BUG=524582 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/422d099ed5b8439b92d198deb84d4528c14ccc0c > Cr-Commit-Position: refs/heads/master@{#347864} TBR=dcastagna@chromium.org,sandersd@chromium.org,ccameron@chromium.org,andresantoso@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524582 Committed: https://crrev.com/9fbd81e3c8adf06f9a77d917050eb99f2cdad3c3 Cr-Commit-Position: refs/heads/master@{#348120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -221 lines) Patch
M cc/resources/video_resource_updater.cc View 2 chunks +47 lines, -55 lines 0 comments Download
M media/base/video_frame.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/blink/skcanvas_video_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/renderers/mock_gpu_video_accelerator_factories.cc View 4 chunks +10 lines, -22 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 11 chunks +42 lines, -118 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tommi (sloooow) - chröme
Created Revert of Add support for converting I420 software frames into NV12 hardware frames
5 years, 3 months ago (2015-09-10 08:54:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327243002/1
5 years, 3 months ago (2015-09-10 08:54:15 UTC) #2
tommi (sloooow) - chröme
+webrtc sheriff
5 years, 3 months ago (2015-09-10 08:54:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 08:54:51 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9fbd81e3c8adf06f9a77d917050eb99f2cdad3c3 Cr-Commit-Position: refs/heads/master@{#348120}
5 years, 3 months ago (2015-09-10 08:55:43 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:08:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fbd81e3c8adf06f9a77d917050eb99f2cdad3c3
Cr-Commit-Position: refs/heads/master@{#348120}

Powered by Google App Engine
This is Rietveld 408576698