Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 132723002: Remove compile time flag TOUCH_ICON_LOADING and use runtime flag instead. (Closed)

Created:
6 years, 11 months ago by maheshkk
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove compile time flag TOUCH_ICON_LOADING and use runtime flag instead. Update layout test case to use runtime flag. Depends on 132173002 and 132163002 BUG=332863 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165160

Patch Set 1 #

Patch Set 2 : Fix code conflict #

Patch Set 3 : Fix unit test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -55 lines) Patch
M LayoutTests/fast/dom/icon-url-list-apple-touch.html View 1 chunk +19 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/icon-url-list-apple-touch-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/build/features.gypi View 1 3 chunks +3 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/IconURL.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/html/LinkRelAttribute.cpp View 3 chunks +25 lines, -25 lines 0 comments Download
M Source/core/html/LinkRelAttributeTest.cpp View 1 2 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
maheshkk
1. Adding dummy runtime flag, committed: https://codereview.chromium.org/132163002/ 2. Enable runtime flag only for android, committed: ...
6 years, 11 months ago (2014-01-13 18:41:44 UTC) #1
maheshkk
abarth when you have few mins please take a look. Thanks.
6 years, 11 months ago (2014-01-15 00:06:19 UTC) #2
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-15 00:15:05 UTC) #3
maheshkk
On 2014/01/15 00:15:05, abarth wrote: > lgtm Thanks for your time!
6 years, 11 months ago (2014-01-15 00:17:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/132723002/1
6 years, 11 months ago (2014-01-15 00:31:41 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/build/features.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-15 00:31:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/132723002/90001
6 years, 11 months ago (2014-01-15 00:45:44 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=17588
6 years, 11 months ago (2014-01-15 15:27:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/132723002/390001
6 years, 11 months ago (2014-01-15 18:34:22 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 19:57:07 UTC) #10
Message was sent while issue was closed.
Change committed as 165160

Powered by Google App Engine
This is Rietveld 408576698