Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1327143002: Make sure getFallbackFamily() always sets *scriptChecked. (Closed)

Created:
5 years, 3 months ago by Jeffrey Yasskin
Modified:
5 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pinned
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make sure getFallbackFamily() always sets *scriptChecked. This avoids an uninitialized read in FontCache::fallbackFontForCharacter(), which assumes the script is set. Found by DrMemory in http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/5885/steps/memory%20test%3A%20content_browsertests/logs/stdio. Committed: https://crrev.com/f4b89b205bb920ed1999a54a787e6a2a4372712f git-svn-id: svn://svn.chromium.org/blink/trunk@202009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/platform/fonts/win/FontFallbackWin.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327143002/1
5 years, 3 months ago (2015-09-09 16:49:26 UTC) #2
Jeffrey Yasskin
5 years, 3 months ago (2015-09-09 16:49:45 UTC) #4
eae
LGTM Thank you!
5 years, 3 months ago (2015-09-09 16:52:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327143002/1
5 years, 3 months ago (2015-09-09 16:53:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/104794)
5 years, 3 months ago (2015-09-09 19:16:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327143002/1
5 years, 3 months ago (2015-09-09 19:31:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/104898)
5 years, 3 months ago (2015-09-09 21:59:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327143002/1
5 years, 3 months ago (2015-09-09 22:01:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327143002/1
5 years, 3 months ago (2015-09-09 22:09:25 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202009
5 years, 3 months ago (2015-09-09 23:13:53 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:04:42 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f4b89b205bb920ed1999a54a787e6a2a4372712f

Powered by Google App Engine
This is Rietveld 408576698