Getting rid of GetDefaultProfile(), clean up of ProfileManager (which was in a serious mess)

Getting rid of GetDefaultProfile(), clean up of ProfileManager (which was in a serious mess)

Finally! GetDefaultProfile goes away for good!

With that I also cleaned up that class and ripped out ancient unneeded functions / type-defs. Re-ordered the function declarations and so on. I am sure that more could be done here, but please first get rid of this function before it gets more children...

BUG=322682
TEXT=covered by existing unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244241

[Mr4D (OOO till 08-26), 2014-01-09 22:19:06]

Please have a look!

[Mr4D (OOO till 08-26), 2014-01-09 22:27:16]

My merge didn't show up any merge conflicts and it compiled locally without
problems. I will therefore start the trybots in a few again.

That said - lets get the review going since GetDefaultProfile is getting
children again (I can smell it...).

[Dmitry Polukhin, 2014-01-09 22:31:02]

LGTM

It looks like you have to specify revision for trybots explicitly using 'git try
-r'.

[rpetterson, 2014-01-10 00:41:07]

Congrats on the deletion! :)

It looks like this is mostly reorganizing code. Is that correct? If not, I'm
happy to read through all of it with a fine toothed comb but if it's mostly
reorg, could you point me to the functional parts that changed? Thanks!

[Mr4D (OOO till 08-26), 2014-01-10 01:36:07]

On 2014/01/10 00:41:07, rpetterson wrote:
> Congrats on the deletion! :)
> 
> It looks like this is mostly reorganizing code. Is that correct? If not, I'm
> happy to read through all of it with a fine toothed comb but if it's mostly
> reorg, could you point me to the functional parts that changed? Thanks!

Thanks! Yes, it is mostly reorganizing code + deletion of dead
functios/declarations/typedefs, etc.

Thanks for your time!

[rpetterson, 2014-01-10 17:50:53]

LGTM

[commit-bot: I haz the power, 2014-01-10 18:04:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/132713002/330001

[commit-bot: I haz the power, 2014-01-10 21:11:49]

Change committed as 244241