Handle ActivityNotFoundException when selecting client cert

Handle ActivityNotFoundException when selecting client cert

Calling KeyChain#choosePrivateKeyAlias calls through to
Context#startActivity, which can throw an ActivityNotFoundException.

This change catches that exception and, instead of crashing, shows a
dialog that explains that selecting client certs is not supported on
that platform.

TEST=SSLClientCertificateRequestTest
BUG=529513
Committed: https://crrev.com/80c449f6fab63e2ccfb8c15a09a2da6a60eb24ae
Cr-Commit-Position: refs/heads/master@{#348442}

[Ian Cullinan, 2015-09-09 00:11:46]

cullinan@amazon.com changed reviewers:
+ yfriedman@chromium.org

[Ian Cullinan, 2015-09-09 00:11:46]

PTAL

[newt (away), 2015-09-09 20:39:15]

newt@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-09-09 20:39:15]

https://codereview.chromium.org/1327103003/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1327103003/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:2248: <message
name="IDS_CLIENT_CERT_UNSUPPORTED_TITLE" desc="Title of a dialog box for when
the operating system does not support client certificate selection">
Could you add a little more context around the word "certficate"? e.g. "SSL
certificate" or whatever it is. As is, the translators might not have enough
context to translate certificate correctly.

[Ian Cullinan, 2015-09-09 21:21:16]

On 2015/09/09 20:39:15, newt wrote:
>
https://codereview.chromium.org/1327103003/diff/1/chrome/android/java/strings...
> File chrome/android/java/strings/android_chrome_strings.grd (right):
> 
>
https://codereview.chromium.org/1327103003/diff/1/chrome/android/java/strings...
> chrome/android/java/strings/android_chrome_strings.grd:2248: <message
> name="IDS_CLIENT_CERT_UNSUPPORTED_TITLE" desc="Title of a dialog box for when
> the operating system does not support client certificate selection">
> Could you add a little more context around the word "certficate"? e.g. "SSL
> certificate" or whatever it is. As is, the translators might not have enough
> context to translate certificate correctly.

I've updated the string descriptions to say "SSL certificate". PTAL, thanks.

[newt (away), 2015-09-09 23:21:31]

On 2015/09/09 21:21:16, Ian Cullinan wrote:
> On 2015/09/09 20:39:15, newt wrote:
> >
>
https://codereview.chromium.org/1327103003/diff/1/chrome/android/java/strings...
> > File chrome/android/java/strings/android_chrome_strings.grd (right):
> > 
> >
>
https://codereview.chromium.org/1327103003/diff/1/chrome/android/java/strings...
> > chrome/android/java/strings/android_chrome_strings.grd:2248: <message
> > name="IDS_CLIENT_CERT_UNSUPPORTED_TITLE" desc="Title of a dialog box for
when
> > the operating system does not support client certificate selection">
> > Could you add a little more context around the word "certficate"? e.g. "SSL
> > certificate" or whatever it is. As is, the translators might not have enough
> > context to translate certificate correctly.
> 
> I've updated the string descriptions to say "SSL certificate". PTAL, thanks.

Strings look good to me. I'll let Yaron handle the rest of the review.

[Yaron, 2015-09-11 17:24:41]

lgtm thanks

[Ian Cullinan, 2015-09-11 17:27:52]

The CQ bit was checked by cullinan@amazon.com

[commit-bot: I haz the power, 2015-09-11 17:28:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327103003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327103003/20001

[commit-bot: I haz the power, 2015-09-11 18:29:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-11 18:30:08]

Patchset 2 (id:??) landed as
https://crrev.com/80c449f6fab63e2ccfb8c15a09a2da6a60eb24ae
Cr-Commit-Position: refs/heads/master@{#348442}

[commit-bot: I haz the power, 2015-09-23 12:24:28]

Patchset 2 (id:??) landed as
https://crrev.com/80c449f6fab63e2ccfb8c15a09a2da6a60eb24ae
Cr-Commit-Position: refs/heads/master@{#348442}