Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 1327083002: Revert "Patched in Dartium JsInterop" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/js/dartium/js_dartium.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/svg/dart2js/svg_dart2js.dart
diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart
index b044efc99e71df4b6fa01ed1fa7ac5673ac521bb..1e63bd22a5ed4d8272f0e2de5dcb940989df6db3 100644
--- a/sdk/lib/svg/dart2js/svg_dart2js.dart
+++ b/sdk/lib/svg/dart2js/svg_dart2js.dart
@@ -2693,7 +2693,7 @@ class LengthList extends Interceptor with ListMixin<Length>, ImmutableListMixin<
// Length is the element type.
- set length(int value) {
+ void set length(int value) {
throw new UnsupportedError("Cannot resize immutable List.");
}
@@ -3145,7 +3145,7 @@ class NumberList extends Interceptor with ListMixin<Number>, ImmutableListMixin<
// Number is the element type.
- set length(int value) {
+ void set length(int value) {
throw new UnsupportedError("Cannot resize immutable List.");
}
@@ -3932,7 +3932,7 @@ class PathSegList extends Interceptor with ListMixin<PathSeg>, ImmutableListMixi
// PathSeg is the element type.
- set length(int value) {
+ void set length(int value) {
throw new UnsupportedError("Cannot resize immutable List.");
}
@@ -4627,7 +4627,7 @@ class StringList extends Interceptor with ListMixin<String>, ImmutableListMixin<
// String is the element type.
- set length(int value) {
+ void set length(int value) {
throw new UnsupportedError("Cannot resize immutable List.");
}
@@ -4731,7 +4731,7 @@ class StyleElement extends SvgElement {
// Shadowing definition.
String get title => JS("String", "#.title", this);
- set title(String value) {
+ void set title(String value) {
JS("void", "#.title = #", this, value);
}
@@ -4801,7 +4801,7 @@ class SvgElement extends Element implements GlobalEventHandlers {
List<Element> get children => new FilteredElementList(this);
- set children(List<Element> value) {
+ void set children(List<Element> value) {
final children = this.children;
children.clear();
children.addAll(value);
@@ -4821,7 +4821,7 @@ class SvgElement extends Element implements GlobalEventHandlers {
return container.innerHtml;
}
- set innerHtml(String value) {
+ void set innerHtml(String value) {
this.setInnerHtml(value);
}
@@ -4886,7 +4886,6 @@ class SvgElement extends Element implements GlobalEventHandlers {
var e = new SvgElement.tag(tag);
return e is SvgElement && !(e is UnknownElement);
}
-
// To suppress missing implicit constructor warnings.
factory SvgElement._() { throw new UnsupportedError("Not supported"); }
@@ -5170,7 +5169,7 @@ class SvgElement extends Element implements GlobalEventHandlers {
// Shadowing definition.
int get tabIndex => JS("int", "#.tabIndex", this);
- set tabIndex(int value) {
+ void set tabIndex(int value) {
JS("void", "#.tabIndex = #", this, value);
}
@@ -6083,7 +6082,7 @@ class TransformList extends Interceptor with ListMixin<Transform>, ImmutableList
// Transform is the element type.
- set length(int value) {
+ void set length(int value) {
throw new UnsupportedError("Cannot resize immutable List.");
}
« no previous file with comments | « sdk/lib/js/dartium/js_dartium.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698