Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: mojo/dart/embedder/io/internet_address_posix.cc

Issue 1327033004: Allow building mojo_shell and non-graphical apps/services on a Mac (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/embedder/io/internet_address_linux.cc ('k') | services/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/embedder/io/internet_address_posix.cc
diff --git a/mojo/dart/embedder/io/internet_address_android.cc b/mojo/dart/embedder/io/internet_address_posix.cc
similarity index 82%
rename from mojo/dart/embedder/io/internet_address_android.cc
rename to mojo/dart/embedder/io/internet_address_posix.cc
index b1440812b08b2723072cd16d0d5b3cdfaffe86f3..74b78fedc7c4a28451193a022f9a632f2f357078 100644
--- a/mojo/dart/embedder/io/internet_address_android.cc
+++ b/mojo/dart/embedder/io/internet_address_posix.cc
@@ -13,7 +13,8 @@ namespace dart {
static void SetupSockAddr(sockaddr_storage* dest,
socklen_t* salen,
- const RawAddr& addr, intptr_t addr_length) {
+ const RawAddr& addr,
+ intptr_t addr_length) {
CHECK((addr_length == 4) || (addr_length == 16));
if (addr_length == 4) {
dest->ss_family = AF_INET;
@@ -44,21 +45,18 @@ bool InternetAddress::Parse(int type, const char* address, RawAddr* addr) {
return result == 1;
}
-bool InternetAddress::Reverse(const RawAddr& addr, intptr_t addr_length,
- char* host, intptr_t host_len,
+bool InternetAddress::Reverse(const RawAddr& addr,
+ intptr_t addr_length,
+ char* host,
+ intptr_t host_len,
intptr_t* error_code,
const char** error_description) {
CHECK(host_len >= NI_MAXHOST);
sockaddr_storage sock_addr;
socklen_t salen;
SetupSockAddr(&sock_addr, &salen, addr, addr_length);
- int status = getnameinfo(reinterpret_cast<sockaddr*>(&sock_addr),
- salen,
- host,
- host_len,
- NULL,
- 0,
- NI_NAMEREQD);
+ int status = getnameinfo(reinterpret_cast<sockaddr*>(&sock_addr), salen, host,
+ host_len, NULL, 0, NI_NAMEREQD);
*error_code = status;
if (status != 0) {
CHECK(*error_description == NULL);
« no previous file with comments | « mojo/dart/embedder/io/internet_address_linux.cc ('k') | services/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698