[test] Add an option to the perf runner to support running with the internal profiler.

tools/run_perf.py

 #!/usr/bin/env python
 # Copyright 2014 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Performance runner for d8.
 
 Call e.g. with tools/run-perf.py --arch ia32 some_suite.json
 
@@ skipping 84 matching lines @@
 The test flags are passed to the js test file after '--'.
 """
 
 from collections import OrderedDict
 import json
 import logging
 import math
 import optparse
 import os
 import re
+import subprocess
 import sys
 
 from testrunner.local import commands
 from testrunner.local import utils
 
 ARCH_GUESS = utils.DefaultArch()
 SUPPORTED_ARCHS = ["arm",
                    "ia32",
                    "mips",
                    "mipsel",
@@ skipping 335 matching lines @@
     suite_dir = os.path.abspath(os.path.dirname(suite_path))
     bench_dir = os.path.normpath(os.path.join(*self.path))
     os.chdir(os.path.join(suite_dir, bench_dir))
 
   def GetCommandFlags(self, extra_flags=None):
     suffix = ["--"] + self.test_flags if self.test_flags else []
     return self.flags + (extra_flags or []) + [self.main] + suffix
 
   def GetCommand(self, shell_dir, extra_flags=None):
     # TODO(machenbach): This requires +.exe if run on windows.
+    extra_flags = extra_flags or []
     cmd = [os.path.join(shell_dir, self.binary)]
+    if self.binary != 'd8' and '--prof' in self.extra_flags:

[Michael Achenbach, 2015/09/15 07:03:40]

Ah crap - didn't catch this. s/self.extra_flags/extra_flags

+      print "Profiler supported only on a benchmark run with d8"
     return cmd + self.GetCommandFlags(extra_flags=extra_flags)
 
   def Run(self, runner, trybot):
     """Iterates over several runs and handles the output for all traces."""
     stdout_with_patch, stdout_no_patch = Unzip(runner())
     return (
         AccumulateResults(
             self.graphs,
             self._children,
             iter_output=stdout_with_patch,
@@ skipping 162 matching lines @@
       print e
       return ""
     print title % "Stdout"
     print output.stdout
     if output.stderr:  # pragma: no cover
       # Print stderr for debugging.
       print title % "Stderr"
       print output.stderr
     if output.timed_out:
       print ">>> Test timed out after %ss." % runnable.timeout
+    if '--prof' in self.extra_flags:
+      if utils.GuessOS() == "linux":
+        tick_tools = os.path.abspath(os.path.join(shell_dir, "..", "..",
+                                                  "tools",
+                                                  "linux-tick-processor"))
+      elif utils.GuessOS() == "macos":
+        tick_tools = os.path.abspath(os.path.join(shell_dir, "..", "..",
+                                                  "tools",
+                                                  "mac-tick-processor"))
+      else:
+        print "Profiler option currently supported on Linux and Mac OS."
+      prof_cmd = tick_tools + " --only-summary"

[Michael Achenbach, 2015/09/15 07:03:40]

In the else case, tick_tools is read before assignment.

+      subprocess.check_call(prof_cmd, shell=True)
     return output.stdout
 
 
 class AndroidPlatform(Platform):  # pragma: no cover
   DEVICE_DIR = "/data/local/tmp/v8/"
 
   def __init__(self, options):
     super(AndroidPlatform, self).__init__(options)
     LoadAndroidBuildTools(options.android_build_tools)
 
@@ skipping 238 matching lines @@
 
   if options.json_test_results_no_patch:
     results_no_patch.WriteToFile(options.json_test_results_no_patch)
   else:  # pragma: no cover
     print results_no_patch
 
   return min(1, len(results.errors))
 
 if __name__ == "__main__":  # pragma: no cover
   sys.exit(Main(sys.argv[1:]))