Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 132703002: The default render object layout implementation is dead code (Closed)

Created:
6 years, 11 months ago by atreat
Modified:
6 years, 11 months ago
Reviewers:
esprehn, Inactive, eseidel
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

The default render object layout implementation is dead code While trying to refactor the render tree layout to be non-recursive I discovered that the default render object layout implementation is dead code. First, I put an assert to find a layouttest that exercised it, but could not find any. Next, I made the method pure virtual to see what subclasses used the default impl and found to my surprise that none do! BUG=331879 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M Source/core/rendering/RenderObject.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
atreat
This is pretty surprising I think, but it is dead code. The two bot failures ...
6 years, 11 months ago (2014-01-10 01:29:56 UTC) #1
esprehn
lgtm, this is awesome.
6 years, 11 months ago (2014-01-10 02:15:53 UTC) #2
Inactive
lgtm
6 years, 11 months ago (2014-01-10 02:45:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/132703002/1
6 years, 11 months ago (2014-01-10 02:45:44 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 06:21:51 UTC) #5
Message was sent while issue was closed.
Change committed as 164846

Powered by Google App Engine
This is Rietveld 408576698