Chromium Code Reviews
Help | Chromium Project | Sign in
(166)

Issue 1327002: Simplify passing of AccessorInfo to interceptors: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by Vitaly Repeshko
Modified:
2 years, 11 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Simplify passing of AccessorInfo to interceptors:

* Use slots on the native stack when possible instead of Relocatable.
* Got rid of a gap in AccessorInfo fields.
* Added test for non-cacheable post-interceptor lookup.

Committed: http://code.google.com/p/v8/source/detail?r=4288

Patch Set 1 #

Total comments: 6

Patch Set 2 : . #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -39 lines) Lint Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/arguments.h View 1 chunk +4 lines, -5 lines 1 comment ? errors Download
M src/arm/stub-cache-arm.cc View 1 chunk +3 lines, -4 lines 0 comments ? errors Download
M src/codegen.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +8 lines, -8 lines 6 comments ? errors Download
M src/stub-cache.cc View 5 chunks +13 lines, -15 lines 0 comments ? errors Download
M src/x64/stub-cache-x64.cc View 1 chunk +3 lines, -4 lines 0 comments ? errors Download
M test/cctest/test-api.cc View 1 1 chunk +32 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 5
Vitaly Repeshko
4 years ago #1
Mads Ager (chromium)
LGTM Are CustomArguments still used elsewhere or can we remove them completely?
4 years ago #2
antonm
LGTM http://codereview.chromium.org/1327002/diff/1/3 File src/arguments.h (right): http://codereview.chromium.org/1327002/diff/1/3#newcode75 src/arguments.h:75: // Cursom arguments replicate a small segment of ...
4 years ago #3
Vitaly Repeshko
On 2010/03/25 14:33:00, Mads Ager wrote: > Are CustomArguments still used elsewhere or can we ...
4 years ago #4
Vitaly Repeshko
4 years ago #5
Thanks for review! Submitted.


-- Vitaly

http://codereview.chromium.org/1327002/diff/1/3
File src/arguments.h (right):

http://codereview.chromium.org/1327002/diff/1/3#newcode75
src/arguments.h:75: // Cursom arguments replicate a small segment of stack that
can be
On 2010/03/25 14:40:53, antonm wrote:
> could you fix it while you are around, please?  Cursom -> Custom.

Done.

http://codereview.chromium.org/1327002/diff/1/3#newcode90
src/arguments.h:90: Object* values_[3];
On 2010/03/25 14:40:53, antonm wrote:
> should we introduce constants to minimize changes?  by no means insisting.

Using ARRAY_SIZE now.

http://codereview.chromium.org/1327002/diff/1/8
File src/stub-cache.cc (right):

http://codereview.chromium.org/1327002/diff/1/8#newcode806
src/stub-cache.cc:806: v8::AccessorInfo info(args.arguments() - 2);
On 2010/03/25 14:40:53, antonm wrote:
> maybe add a special method/constructor?  this 2 looks too magical imho

I don't think it really makes sense to have a method/constructor. Added a named
constant and a few assert-s instead.

http://codereview.chromium.org/1327002/diff/3001/4006
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/1327002/diff/3001/4006#newcode1043
src/ia32/stub-cache-ia32.cc:1043: __ mov(other, esp);
On 2010/03/25 14:40:53, antonm wrote:
> Do we need to push the address?

Yes, please see below. It's internal::Object** from AccessorInfo.

http://codereview.chromium.org/1327002/diff/3001/4006#newcode1054
src/ia32/stub-cache-ia32.cc:1054: __ add(Operand(eax), Immediate(4 *
kPointerSize));
On 2010/03/25 14:40:53, antonm wrote:
> could we use some named constant for this 4?

This is a local thing: it's the depth of the arguments pointer as described in
the comment.

http://codereview.chromium.org/1327002/diff/3001/4006#newcode1058
src/ia32/stub-cache-ia32.cc:1058: ASSERT_EQ(5, ApiGetterEntryStub::kStackSpace);
On 2010/03/25 14:40:53, antonm wrote:
> do you I understand it right, this is not ported to other platforms?  do you
> know if we have corresponding bugs filed?

Right, this is not ported to other platforms and I couldn't find a relevant bug.
Filed http://code.google.com/p/v8/issues/detail?id=663
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6