Chromium Code Reviews| Index: chrome/common/net/net_error_info.h |
| diff --git a/chrome/common/net/net_error_info.h b/chrome/common/net/net_error_info.h |
| index 9f8d08a1baabe1b741fa69d2761ec50ff59ae667..5a182f2f6eae715483e16125a9c7f14a09b1d7fb 100644 |
| --- a/chrome/common/net/net_error_info.h |
| +++ b/chrome/common/net/net_error_info.h |
| @@ -7,14 +7,53 @@ |
| namespace chrome_common_net { |
| -enum DnsProbeResult { |
| - DNS_PROBE_UNKNOWN, |
| - DNS_PROBE_NO_INTERNET, |
| - DNS_PROBE_BAD_CONFIG, |
| - DNS_PROBE_NXDOMAIN, |
| +// The status of a DNS probe that the NetErrorTabHelper may or may not have |
| +// started. |
| +// |
| +// The DNS_PROBE_FINISHED_* values are used in histograms, so: |
| +// 1. FINISHED_UNKNOWN must remain the first FINISHED_* value. |
| +// 2. FINISHED_* values must not be rearranged relative to FINISHED_UNKNOWN. |
| +// 3. New FINISHED_* values must be inserted at the end. |
| +// 4. New non-FINISHED_* values must be inserted before FINISHED_UNKNOWN. |
| +enum DnsProbeStatus { |
| + // A DNS probe may be run for this error page. (This status is only used on |
| + // the renderer side before it's received a status update from the browser.) |
| + DNS_PROBE_POSSIBLE, |
| + |
| + // A DNS probe will not be run for this error page. (This happens if the |
| + // user has the "Use web service to resolve navigation errors" preference |
| + // turned off, or if probes are disabled by the field trial.) |
| + DNS_PROBE_NOT_RUN, |
| + |
| + // A DNS probe has been started for this error page. The renderer should |
| + // expect to receive another IPC with one of the FINISHED statuses once the |
| + // probe has finished (as long as the error page is still loaded). |
| + DNS_PROBE_STARTED, |
| + |
| + // A DNS probe has finished with one of the following results: |
| + |
| + // The probe was inconclusive.. |
| + DNS_PROBE_FINISHED_UNKNOWN, |
|
mmenke
2013/07/12 19:51:22
optional: Think DNS_PROBE_INCONCLUSIVE may be cle
Deprecated (see juliatuttle)
2013/07/12 20:55:55
Done.
|
| + |
| + // There's no internet connection. |
| + DNS_PROBE_FINISHED_NO_INTERNET, |
| + |
| + // The DNS configuration is wrong, or the servers are down or broken. |
| + DNS_PROBE_FINISHED_BAD_CONFIG, |
| + |
| + // The DNS servers are working fine, so the domain must not exist. |
| + DNS_PROBE_FINISHED_NXDOMAIN, |
| + |
| DNS_PROBE_MAX |
| }; |
| +const char* DnsProbeStatusToString(int status); |
| +bool DnsProbeStatusIsFinished(DnsProbeStatus status); |
| + |
| +bool DnsProbesEnabledByFieldTrial(); |
| + |
| +extern const char kDnsProbeErrorDomain[]; |
| + |
| } // namespace chrome_common_net |
| #endif // CHROME_COMMON_NET_NET_ERROR_INFO_H_ |