Display DNS probe results.

chrome/common/net/net_error_info.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "base/metrics/field_trial.h"
+#include "chrome/common/net/net_error_info.h"
+
+namespace chrome_common_net {
+
+const char kDnsProbeErrorDomain[] = "dnsprobe";
+
+const char* DnsProbeStatusToString(int status) {
+  switch (status) {
+  case DNS_PROBE_POSSIBLE:
+    return "DNS_PROBE_POSSIBLE";
+  case DNS_PROBE_NOT_RUN:
+    return "DNS_PROBE_NOT_RUN";
+  case DNS_PROBE_STARTED:
+    return "DNS_PROBE_STARTED";
+  case DNS_PROBE_FINISHED_UNKNOWN:
+    return "DNS_PROBE_FINISHED_UNKNOWN";
+  case DNS_PROBE_FINISHED_NO_INTERNET:
+    return "DNS_PROBE_FINISHED_NO_INTERNET";
+  case DNS_PROBE_FINISHED_BAD_CONFIG:
+    return "DNS_PROBE_FINISHED_BAD_CONFIG";
+  case DNS_PROBE_FINISHED_NXDOMAIN:
+    return "DNS_PROBE_FINISHED_NXDOMAIN";
+  default:
+    NOTREACHED();
+    return "";
+  }
+}
+
+bool DnsProbeStatusIsFinished(DnsProbeStatus status) {
+  return status >= DNS_PROBE_FINISHED_UNKNOWN
+         && status < DNS_PROBE_MAX;

[mmenke, 2013/06/12 19:17:12]

nit:  Put "&&" on the previous line.

[Deprecated (see juliatuttle), 2013/06/13 14:37:04]

Done.

+}
+
+bool DnsProbesEnabledByFieldTrial() {
+  static const char kDnsProbeFieldTrialName[] = "DnsProbe-Enable";
+  static const char kDnsProbeFieldTrialEnableGroupName[] = "enable";

[mmenke, 2013/06/12 19:17:12]

I believe it was mentioned on the mailing list that this creates bad code on
some platforms, as it does the whole initialize-static-on-first-call thing. 
"const char" is the way to go (Or const char?  Can't remember if one was
preferred over the other).

[Deprecated (see juliatuttle), 2013/06/13 14:37:04]

Done.

+
+  return base::FieldTrialList::FindFullName(kDnsProbeFieldTrialName)
+         == kDnsProbeFieldTrialEnableGroupName;

[mmenke, 2013/06/12 19:17:12]

nit:  Put "==" on previous line, if it fits.

[Deprecated (see juliatuttle), 2013/06/13 14:37:04]

Done.

+}
+
+}  // namespace chrome_common_net