Add the ability for MDnsListener to actively refresh records

net/dns/mdns_client_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <queue>
 
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "net/base/rand_callback.h"
 #include "net/base/test_completion_callback.h"
@@ skipping 223 matching lines @@
   // Question
   // This part is echoed back from the respective query.
   0x07, '_', 'p', 'r', 'i', 'v', 'e', 't',
   0x04, '_', 't', 'c', 'p',
   0x05, 'l', 'o', 'c', 'a', 'l',
   0x00,
   0x00, 0x0c,        // TYPE is PTR.
   0x00, 0x01,        // CLASS is IN.
 };
 
+const uint8 kQueryPacketPrivetA[] = {
+  // Header
+  0x00, 0x00,               // ID is zeroed out
+  0x00, 0x00,               // No flags.
+  0x00, 0x01,               // One question.
+  0x00, 0x00,               // 0 RRs (answers)
+  0x00, 0x00,               // 0 authority RRs
+  0x00, 0x00,               // 0 additional RRs
+
+  // Question
+  // This part is echoed back from the respective query.
+  0x07, '_', 'p', 'r', 'i', 'v', 'e', 't',
+  0x04, '_', 't', 'c', 'p',
+  0x05, 'l', 'o', 'c', 'a', 'l',
+  0x00,
+  0x00, 0x01,        // TYPE is A.
+  0x00, 0x01,        // CLASS is IN.
+};
+
 const uint8 kSamplePacketAdditionalOnly[] = {
   // Header
   0x00, 0x00,               // ID is zeroed out
   0x81, 0x80,               // Standard query response, RA, no error
   0x00, 0x00,               // No questions (for simplicity)
   0x00, 0x00,               // 2 RRs (answers)
   0x00, 0x00,               // 0 authority RRs
   0x00, 0x01,               // 0 additional RRs
 
   // Answer 1
@@ skipping 42 matching lines @@
   0x00, 0x00,               // 0 authority RRs
   0x00, 0x00,               // 0 additional RRs
 
   // Answer 1
   0x07, '_', 'p', 'r', 'i', 'v', 'e', 't',
   0x04, '_', 't', 'c', 'p',
   0x05, 'l', 'o', 'c', 'a', 'l',
   0x00,
   0x00, 0x01,        // TYPE is A.
   0x00, 0x01,        // CLASS is IN.
-  0x00, 0x01,        // TTL (4 bytes) is 20 hours, 47 minutes, 48 seconds.
-  0x24, 0x74,
+  0x00, 0x00,        // TTL (4 bytes) is 5 seconds
+  0x00, 0x05,
   0x00, 0x04,        // RDLENGTH is 4 bytes.
   0xc0, 0x0c,
   0x00, 0x02,
 };
 
 const uint8 kSamplePacketGoodbye[] = {
   // Header
   0x00, 0x00,               // ID is zeroed out
   0x81, 0x80,               // Standard query response, RA, no error
   0x00, 0x00,               // No questions (for simplicity)
@@ skipping 683 matching lines @@
   EXPECT_CALL(delegate_privet,
               OnNsecRecord("_privet._tcp.local", dns_protocol::kTypeA));
 
   SimulatePacketReceive(kSamplePacketNsec,
                         sizeof(kSamplePacketNsec));
 
   EXPECT_EQ(record1, record2);
 }
 
 
+TEST_F(MDnsTest, RefreshQuery) {
+  StrictMock<MockListenerDelegate> delegate_privet;
+  scoped_ptr<MDnsListener> listener_privet =
+      test_client_.CreateListener(dns_protocol::kTypeA, "_privet._tcp.local",
+                                  &delegate_privet);
+
+  listener_privet->SetActiveRefresh(true);
+  ASSERT_TRUE(listener_privet->Start());
+
+  EXPECT_CALL(delegate_privet, OnRecordUpdate(MDnsListener::RECORD_ADDED, _));
+
+  SimulatePacketReceive(kSamplePacketAPrivet,
+                        sizeof(kSamplePacketAPrivet));
+
+  // Expecting 2 calls (one for ipv4 and one for ipv6) at 85% of the TTL and 2
+  // calls at 95% of the TTL.

[szym, 2014/01/29 19:08:39]

nit: I'd remove the 85% and 95% numbers from this comment.
// Expecting 2 calls (one for IPv4 and one for IPv6) for each of the 2 scheduled
refresh queries.

[Noam Samuel, 2014/01/29 19:21:36]

Done.

+  EXPECT_CALL(socket_factory_, OnSendTo(
+      MakeString(kQueryPacketPrivetA, sizeof(kQueryPacketPrivetA))))
+      .Times(4);
+
+  EXPECT_CALL(delegate_privet, OnRecordUpdate(MDnsListener::RECORD_REMOVED, _));
+
+  RunFor(base::TimeDelta::FromSeconds(6));
+}
+
 // Note: These tests assume that the ipv4 socket will always be created first.
 // This is a simplifying assumption based on the way the code works now.
 class SimpleMockSocketFactory : public MDnsSocketFactory {
  public:
   virtual void CreateSockets(
       ScopedVector<DatagramServerSocket>* sockets) OVERRIDE {
     sockets->clear();
     sockets->swap(sockets_);
   }
 
@@ skipping 111 matching lines @@
 
   ASSERT_TRUE(InitConnection());
 
   EXPECT_CALL(delegate_, OnConnectionError(ERR_SOCKET_NOT_CONNECTED));
   callback.Run(ERR_SOCKET_NOT_CONNECTED);
 }
 
 }  // namespace
 
 }  // namespace net