Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 132693004: PNaCl: Add "not" to various test commands, to pass under LLVM 3.4 (Closed)

Created:
6 years, 11 months ago by Mark Seaborn
Modified:
6 years, 11 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

PNaCl: Add "not" to various test commands, to pass under LLVM 3.4 In LLVM 3.4, llvm-lit got stricter, so that the command "X | Y" is treated as failing if X returns a non-zero exit status. (llvm-lit sets "pipefail" in Bash.) The way to fix this is to write "not X | Y" instead. Mostly fixed with: perl -pi -e 's/RUN: pnacl-abicheck/RUN: not pnacl-abicheck/' $(git ls-files test/NaCl/PNaClABI/) BUG=https://code.google.com/p/nativeclient/issues/detail?id=3757 TEST=tested with LLVM 3.4 merged R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=803421a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M test/NaCl/PNaClABI/abi-addrspace.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-aliases.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-alignment.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-arithmetic-attributes.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-bad-intrinsic.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-blockaddress.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-call-attributes.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-debug-info.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M test/NaCl/PNaClABI/abi-externals-whitelist.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-flattened-globals.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-i1-operations.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-metadata.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M test/NaCl/PNaClABI/abi-small-arguments.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-stripped-pointers.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-switch.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-varargs.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/abi-visibility.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/global-attributes.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/instructions.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/intrinsics.ll View 1 chunk +2 lines, -2 lines 0 comments Download
M test/NaCl/PNaClABI/linkagetypes.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/module-asm.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/types.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/NaCl/PNaClABI/types-function.ll View 1 chunk +1 line, -1 line 0 comments Download
M test/Transforms/NaCl/rewrite-setjmp-store-error.ll View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
6 years, 11 months ago (2014-01-21 17:29:37 UTC) #1
Derek Schuff
lgtm
6 years, 11 months ago (2014-01-21 18:33:51 UTC) #2
Mark Seaborn
6 years, 11 months ago (2014-01-21 18:37:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r803421a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698