Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 132683004: [Files.app] Change sort timing during metadata fetch (Closed)

Created:
6 years, 11 months ago by yoshiki
Modified:
6 years, 11 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Files.app] Change sort timing during metadata fetch This patch is a reland of r243816, fixing the tiny typo. Previously, sort was not started until all the metadata is fetched. When fetching took a time, the user saw unsorted list for a while. With this patch, sort is happened just after every updates. User can see sorted list every time. BUG=327479 TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244205

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -23 lines) Patch
M chrome/browser/resources/file_manager/foreground/js/directory_contents.js View 1 6 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/metadata/metadata_cache.js View 1 2 5 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
lgtm, thx!
6 years, 11 months ago (2014-01-10 05:38:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/132683004/40001
6 years, 11 months ago (2014-01-10 05:43:20 UTC) #2
mtomasz
On 2014/01/10 05:43:20, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 11 months ago (2014-01-10 05:45:08 UTC) #3
yoshiki
Opps, sorry. PTAL at the patch set 3 again?
6 years, 11 months ago (2014-01-10 05:48:32 UTC) #4
mtomasz
LGTM!
6 years, 11 months ago (2014-01-10 05:50:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/132683004/170001
6 years, 11 months ago (2014-01-10 14:51:59 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 18:41:20 UTC) #7
Message was sent while issue was closed.
Change committed as 244205

Powered by Google App Engine
This is Rietveld 408576698