LayoutTests/http/tests/security/contentSecurityPolicy/resources/frame-ancestors-and-x-frame-options.pl - Issue 1326823003: CSP: 'frame-ancestors' should override 'x-frame-options'.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/security/contentSecurityPolicy/resources/frame-ancestors-and-x-frame-options.pl

Issue 1326823003: CSP: 'frame-ancestors' should override 'x-frame-options'. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-xfo.html ('k') | Source/core/frame/csp/CSPDirectiveList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 #!/usr/bin/perl	1 #!/usr/bin/perl

2 use strict;	2 use strict;

3 use CGI;	3 use CGI;

4	4

5 my $cgi = new CGI;	5 my $cgi = new CGI;

6	6

7 print "Content-Type: text/html; charset=UTF-8\n";	7 print "Content-Type: text/html; charset=UTF-8\n";

8 print "Content-Security-Policy: frame-ancestors " . $cgi->param("policy") . "\n\ n";	8 print "Content-Security-Policy: frame-ancestors " . $cgi->param("policy") . "\n" ;

	9 print "X-Frame-Options: " . $cgi->param("xfo") . "\n\n";
	estark 2015/09/08 18:15:47 Confusion: when $cgi->param("xfo") is empty, how d Confusion: when $cgi->param("xfo") is empty, how does this not hit the ASSERT_NOT_REACHED here: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... Won't an empty X-Frame-Options value cause parseXFrameOptionsDisposition() (https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...) to return XFrameOptionsNone which will hit the default case of the switch statement in shouldInterruptLoadForXFrameOptions()? estark 2015/09/08 18:18:20 Oh wait, duh, it will only hit the ASSERT_NOT_REAC Show quoted text On 2015/09/08 18:15:47, estark wrote: > Confusion: when $cgi->param("xfo") is empty, how does this not hit the > ASSERT_NOT_REACHED here: > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... > > Won't an empty X-Frame-Options value cause parseXFrameOptionsDisposition() > (https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...) > to return XFrameOptionsNone which will hit the default case of the switch > statement in shouldInterruptLoadForXFrameOptions()? Oh wait, duh, it will only hit the ASSERT_NOT_REACHED if frame-ancestors is not enforced, so I guess this is fine unless the served CSP doesn't parse or something like that. So, confusion resolved, sorry for the noise. :)
9	10

10 print "<!DOCTYPE html>\n";	11 print "<!DOCTYPE html>\n";

11 print "<html>\n";	12 print "<html>\n";

12 print "<body>\n";	13 print "<body>\n";

13 print " <p>This is an IFrame sending a Content Security Policy header contain ing \"frame-ancestors " . $cgi->param("policy") . "\".</p>\n";	14 print " <p>This is an IFrame sending a Content Security Policy header contain ing \"frame-ancestors " . $cgi->param("policy") . "\" and \"X-Frame-Options: " . $cgi->param("xfo") . "\".</p>\n";

14 print "</body>\n";	15 print "</body>\n";

15 print "</html>\n";	16 print "</html>\n";

OLD	NEW