Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Issue 1326813003: Tweak logging in incremental_install.py to know when each part is done (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@device-more-caching
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --verbose flag to incremental_install.py BUG=520082 Committed: https://crrev.com/d1c2ae8a9291ef00d6ebd6bda2a269d562a285e1 Cr-Commit-Position: refs/heads/master@{#347711}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add verbose flag #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M build/android/incremental_install.py View 1 4 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
agrieve
5 years, 3 months ago (2015-09-02 18:03:26 UTC) #2
jbudorick
https://codereview.chromium.org/1326813003/diff/1/build/android/incremental_install.py File build/android/incremental_install.py (right): https://codereview.chromium.org/1326813003/diff/1/build/android/incremental_install.py#newcode95 build/android/incremental_install.py:95: logging.info('Finished installing .apk') I know this feeling. I'd recommend ...
5 years, 3 months ago (2015-09-02 18:14:20 UTC) #3
agrieve
https://codereview.chromium.org/1326813003/diff/1/build/android/incremental_install.py File build/android/incremental_install.py (right): https://codereview.chromium.org/1326813003/diff/1/build/android/incremental_install.py#newcode95 build/android/incremental_install.py:95: logging.info('Finished installing .apk') On 2015/09/02 18:14:19, jbudorick wrote: > ...
5 years, 3 months ago (2015-09-02 18:34:04 UTC) #4
agrieve
On 2015/09/02 18:34:04, agrieve wrote: > https://codereview.chromium.org/1326813003/diff/1/build/android/incremental_install.py > File build/android/incremental_install.py (right): > > https://codereview.chromium.org/1326813003/diff/1/build/android/incremental_install.py#newcode95 > ...
5 years, 3 months ago (2015-09-04 13:56:44 UTC) #5
jbudorick
lgtm
5 years, 3 months ago (2015-09-08 15:03:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326813003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326813003/40001
5 years, 3 months ago (2015-09-08 15:07:49 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-08 16:16:14 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 16:17:05 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1c2ae8a9291ef00d6ebd6bda2a269d562a285e1
Cr-Commit-Position: refs/heads/master@{#347711}

Powered by Google App Engine
This is Rietveld 408576698