Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1326763003: Clean up the useless GetAttributedSubstringFromRange() and the related IPC. (Closed)

Created:
5 years, 3 months ago by Shu Chen
Modified:
5 years, 3 months ago
Reviewers:
palmer, no sievers
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up the useless GetAttributedSubstringFromRange() and the related IPC. This is based on 2 CLs: - https://codereview.chromium.org/1313553006 - https://codereview.chromium.org/1327743002 BUG=121917 Committed: https://crrev.com/fbadac5baf4b1d032782b7129088a29341de9598 Cr-Commit-Position: refs/heads/master@{#350182}

Patch Set 1 #

Patch Set 2 : rebased. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -68 lines) Patch
M content/browser/renderer_host/text_input_client_mac.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac.mm View 1 2 4 chunks +0 lines, -33 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac_unittest.mm View 1 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Shu Chen
5 years, 3 months ago (2015-09-02 05:06:14 UTC) #2
palmer
LGTM. Note that you don't need that TEST line in your CL description; that line ...
5 years, 3 months ago (2015-09-02 20:02:32 UTC) #3
no sievers
lgtm
5 years, 3 months ago (2015-09-03 20:23:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326763003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326763003/40001
5 years, 3 months ago (2015-09-22 17:02:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-22 17:29:01 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 17:29:31 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fbadac5baf4b1d032782b7129088a29341de9598
Cr-Commit-Position: refs/heads/master@{#350182}

Powered by Google App Engine
This is Rietveld 408576698