Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1326743004: Give reason while file open failed. (Closed)

Created:
5 years, 3 months ago by bungeman-skia
Modified:
5 years, 3 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/ports/SkOSFile_stdio.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
bungeman-skia
5 years, 3 months ago (2015-09-02 18:15:23 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326743004/1
5 years, 3 months ago (2015-09-02 18:15:35 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-02 18:21:06 UTC) #6
djsollen
https://codereview.chromium.org/1326743004/diff/1/src/ports/SkOSFile_stdio.cpp File src/ports/SkOSFile_stdio.cpp (right): https://codereview.chromium.org/1326743004/diff/1/src/ports/SkOSFile_stdio.cpp#newcode38 src/ports/SkOSFile_stdio.cpp:38: path, perm, errno, strerror(errno))); fix spacing but otherwise lgtm
5 years, 3 months ago (2015-09-02 18:44:06 UTC) #7
bungeman-skia
https://codereview.chromium.org/1326743004/diff/1/src/ports/SkOSFile_stdio.cpp File src/ports/SkOSFile_stdio.cpp (right): https://codereview.chromium.org/1326743004/diff/1/src/ports/SkOSFile_stdio.cpp#newcode38 src/ports/SkOSFile_stdio.cpp:38: path, perm, errno, strerror(errno))); On 2015/09/02 18:44:06, djsollen wrote: ...
5 years, 3 months ago (2015-09-02 19:35:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326743004/20001
5 years, 3 months ago (2015-09-02 19:36:05 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 19:41:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0881b95b44c011203e30cf36e11855987964df45

Powered by Google App Engine
This is Rietveld 408576698