Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1326703002: Revert of ipc: Add a new field num_brokered_attachments to the message header. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ipc: Add a new field num_brokered_attachments to the message header. (patchset #1 id:1 of https://codereview.chromium.org/1311673011/ ) Reason for revert: Causes crashes on Canary: https://code.google.com/p/chromium/issues/detail?id=524032 Original issue's description: > ipc: Add a new field num_brokered_attachments to the message header. > > BUG=493414 > > Committed: https://crrev.com/9e3e945e56139cf34634dc21ad25a67fc5507590 > Cr-Commit-Position: refs/heads/master@{#346426} TBR=tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493414 Committed: https://crrev.com/01eb81a73adc66c3e8a5385ec6aed81a93450940 Cr-Commit-Position: refs/heads/master@{#346692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M ipc/ipc_message.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ipc/ipc_message.cc View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of ipc: Add a new field num_brokered_attachments to the message header.
5 years, 3 months ago (2015-09-01 18:24:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326703002/1
5 years, 3 months ago (2015-09-01 18:24:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 18:25:54 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 18:26:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01eb81a73adc66c3e8a5385ec6aed81a93450940
Cr-Commit-Position: refs/heads/master@{#346692}

Powered by Google App Engine
This is Rietveld 408576698