Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1326683005: Adding megjablon and removing jeremyim from Data Reduction Proxy OWNERS files. (Closed)

Created:
5 years, 3 months ago by megjablon
Modified:
5 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding megjablon to Data Reduction Proxy OWNERS files and removing jeremyim from OWNERS and histogram owners. BUG= Committed: https://crrev.com/d886f59807f369c603f3320700f51a84414af385 Cr-Commit-Position: refs/heads/master@{#348742}

Patch Set 1 #

Patch Set 2 : remove jeremyim from owners #

Patch Set 3 : add newline #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M chrome/browser/net/spdyproxy/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/OWNERS View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M components/data_reduction_proxy/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/resources/OWNERS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/test/data/data_reduction_proxy/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 9 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 35 (16 generated)
megjablon
bengr: all blundell: components/OWNERS and components/resources/OWNERS
5 years, 3 months ago (2015-09-08 23:08:48 UTC) #2
blundell
lgtm
5 years, 3 months ago (2015-09-09 08:38:44 UTC) #3
bengr
lgtm. While you're here, do you want to see if jeremyim wants to be removed ...
5 years, 3 months ago (2015-09-11 12:32:12 UTC) #4
megjablon
asvitkine: histograms.xml
5 years, 3 months ago (2015-09-11 17:39:27 UTC) #6
jeremyim
lgtm
5 years, 3 months ago (2015-09-11 17:40:37 UTC) #7
Alexei Svitkine (slow)
histograms lgtm Please mention the patchset 2 changes too. :)
5 years, 3 months ago (2015-09-11 17:49:40 UTC) #8
megjablon
On 2015/09/11 17:49:40, Alexei Svitkine wrote: > histograms lgtm > > Please mention the patchset ...
5 years, 3 months ago (2015-09-11 17:51:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326683005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326683005/20001
5 years, 3 months ago (2015-09-11 17:52:06 UTC) #12
commit-bot: I haz the power
Failed to apply patch for components/resources/OWNERS: While running git apply --index -3 -p1; error: patch ...
5 years, 3 months ago (2015-09-11 19:08:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326683005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326683005/40001
5 years, 3 months ago (2015-09-11 19:12:34 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/68250) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-11 19:14:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326683005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326683005/80001
5 years, 3 months ago (2015-09-11 21:17:46 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/102148)
5 years, 3 months ago (2015-09-11 21:48:28 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326683005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326683005/80001
5 years, 3 months ago (2015-09-11 22:47:45 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/112608)
5 years, 3 months ago (2015-09-11 23:08:11 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326683005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326683005/80001
5 years, 3 months ago (2015-09-14 17:54:37 UTC) #32
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 3 months ago (2015-09-14 22:22:21 UTC) #33
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/d886f59807f369c603f3320700f51a84414af385 Cr-Commit-Position: refs/heads/master@{#348742}
5 years, 3 months ago (2015-09-14 22:23:18 UTC) #34
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:09 UTC) #35
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d886f59807f369c603f3320700f51a84414af385
Cr-Commit-Position: refs/heads/master@{#348742}

Powered by Google App Engine
This is Rietveld 408576698