Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1326663002: Fixed not to append the model id when fake video device is enabled. (Closed)

Created:
5 years, 3 months ago by msu.koo
Modified:
5 years, 3 months ago
Reviewers:
tonikitoo_, mcasas
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed not to append the model id when fake video device is enabled. BUG=526633 Committed: https://crrev.com/1835d414dbd8ae8a8e9aa2c70d612b09f4c07785 Cr-Commit-Position: refs/heads/master@{#349146}

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M media/capture/video/video_capture_device.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 21 (5 generated)
msu.koo
PTAL :)
5 years, 3 months ago (2015-09-01 13:42:14 UTC) #2
msu.koo
5 years, 3 months ago (2015-09-02 05:33:27 UTC) #4
tonikitoo_
On 2015/09/02 05:33:27, esnada wrote: informal l g t m. I will defer to others ...
5 years, 3 months ago (2015-09-02 13:18:59 UTC) #5
mcasas
https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc File media/capture/video/video_capture_device.cc (right): https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc#newcode22 media/capture/video/video_capture_device.cc:22: // Ignore |model_id| if |kUseFakeDeviceForMediaStream| flag is present. Hmm ...
5 years, 3 months ago (2015-09-04 02:24:51 UTC) #6
msu.koo
https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc File media/capture/video/video_capture_device.cc (right): https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc#newcode22 media/capture/video/video_capture_device.cc:22: // Ignore |model_id| if |kUseFakeDeviceForMediaStream| flag is present. Thank ...
5 years, 3 months ago (2015-09-05 07:58:11 UTC) #7
mcasas
https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc File media/capture/video/video_capture_device.cc (right): https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc#newcode22 media/capture/video/video_capture_device.cc:22: // Ignore |model_id| if |kUseFakeDeviceForMediaStream| flag is present. On ...
5 years, 3 months ago (2015-09-08 17:50:15 UTC) #8
msu.koo
https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc File media/capture/video/video_capture_device.cc (right): https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc#newcode22 media/capture/video/video_capture_device.cc:22: // Ignore |model_id| if |kUseFakeDeviceForMediaStream| flag is present. I ...
5 years, 3 months ago (2015-09-11 07:08:50 UTC) #9
mcasas
https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc File media/capture/video/video_capture_device.cc (right): https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc#newcode22 media/capture/video/video_capture_device.cc:22: // Ignore |model_id| if |kUseFakeDeviceForMediaStream| flag is present. On ...
5 years, 3 months ago (2015-09-15 17:11:50 UTC) #10
msu.koo
On 2015/09/15 17:11:50, mcasas wrote: > https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc > File media/capture/video/video_capture_device.cc (right): > > https://codereview.chromium.org/1326663002/diff/1/media/capture/video/video_capture_device.cc#newcode22 > ...
5 years, 3 months ago (2015-09-16 00:06:12 UTC) #11
mcasas
LGTM, thanks!
5 years, 3 months ago (2015-09-16 15:17:44 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326663002/20001
5 years, 3 months ago (2015-09-16 15:18:09 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 16:36:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326663002/20001
5 years, 3 months ago (2015-09-16 16:47:35 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 16:54:09 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1835d414dbd8ae8a8e9aa2c70d612b09f4c07785 Cr-Commit-Position: refs/heads/master@{#349146}
5 years, 3 months ago (2015-09-16 16:55:38 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:57:04 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1835d414dbd8ae8a8e9aa2c70d612b09f4c07785
Cr-Commit-Position: refs/heads/master@{#349146}

Powered by Google App Engine
This is Rietveld 408576698