Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3788)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java

Issue 1326643003: Overlay content is its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-panel-functionality
Patch Set: flip booleans for testing renamed api Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
index e370194fea11e21d1d36f2ac2829aa41a16c3b9a..59cddb3f67aeeebd63f508895655b339428ac4ba 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
@@ -6,9 +6,9 @@ package org.chromium.chrome.browser.compositor.bottombar.contextualsearch;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.ChromeActivity;
+import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelContent;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel.PanelState;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel.StateChangeReason;
-import org.chromium.chrome.browser.contextualsearch.ContextualSearchContentController;
import org.chromium.content.browser.ContentViewCore;
/**
@@ -167,29 +167,29 @@ public interface ContextualSearchPanelDelegate {
boolean isContentViewShowing();
/**
- * Create a new ContentViewCore for this panel.
+ * @return True if the panel loaded a URL.
*/
- void createNewPanelContentView();
+ boolean didLoadAnyUrl();
/**
- * Set the ContextualSearchContentController (for testing).
+ * Sets the top control state based on the internals of the panel.
*/
- @VisibleForTesting
- void setContentController(ContextualSearchContentController controller);
+ void updateTopControlState();
/**
- * @return The current content controller.
+ * Notify the panel that the ContentViewCore was seen.
*/
- @VisibleForTesting
- ContextualSearchContentController getContentController();
+ void setWasSearchContentViewSeen();
/**
- * @return True if the panel loaded a URL.
+ * Sets the visibility of the Search Content View.
+ * @param isVisible True to make it visible.
*/
- boolean didLoadAnyUrl();
+ void setSearchContentViewVisibility(boolean isVisible);
/**
- * Sets the top control state based on the internals of the panel.
+ * @param panelContent The OverlayPanelContent that this panel should use.
*/
- void updateTopControlState();
+ @VisibleForTesting
+ void setOverlayPanelContent(OverlayPanelContent panelContent);
}

Powered by Google App Engine
This is Rietveld 408576698