Moved render_font to a common location to share with other content.

Moved render_font to a common location to share with other content.
This patch moves the render_font_warmup_win files into a common
location so that other content processes, especially PPAPI can
share the code. This is needed as a warmup to pushing win32k lockdown
to other content processes.

BUG=523278
Committed: https://crrev.com/98e2c9d0ab8df5447042c4884dad40910d1c8aa2
Cr-Commit-Position: refs/heads/master@{#348779}

[forshaw, 2015-09-03 00:04:24]

forshaw@chromium.org changed reviewers:
+ palmer@chromium.org, wfh@chromium.org

[forshaw, 2015-09-03 00:04:24]

Please take a look.

[palmer, 2015-09-11 22:53:09]

https://codereview.chromium.org/1326623002/diff/1/content/common/render_font_...
File content/common/render_font_warmup_win.cc (right):

https://codereview.chromium.org/1326623002/diff/1/content/common/render_font_...
content/common/render_font_warmup_win.cc:49: return
reinterpret_cast<SC_HANDLE>(0xdeadbabe);
Since the code re-uses these constants in a few places, give them
kMagicPointerFoo names.

Also, I might not use that value; it's kind of gross. Maybe 0xdeadbadd.

[forshaw, 2015-09-11 23:05:06]

https://codereview.chromium.org/1326623002/diff/1/content/common/render_font_...
File content/common/render_font_warmup_win.cc (right):

https://codereview.chromium.org/1326623002/diff/1/content/common/render_font_...
content/common/render_font_warmup_win.cc:49: return
reinterpret_cast<SC_HANDLE>(0xdeadbabe);
On 2015/09/11 22:53:09, palmer wrote:
> Since the code re-uses these constants in a few places, give them
> kMagicPointerFoo names.
> 
> Also, I might not use that value; it's kind of gross. Maybe 0xdeadbadd.

What's the policy when it's just a move of a file? None of this part is actually
my code, I just moved it from one location to another so that PPAPI could use
it.

[Will Harris, 2015-09-11 23:08:52]

On 2015/09/11 23:05:06, forshaw wrote:
>
https://codereview.chromium.org/1326623002/diff/1/content/common/render_font_...
> File content/common/render_font_warmup_win.cc (right):
> 
>
https://codereview.chromium.org/1326623002/diff/1/content/common/render_font_...
> content/common/render_font_warmup_win.cc:49: return
> reinterpret_cast<SC_HANDLE>(0xdeadbabe);
> On 2015/09/11 22:53:09, palmer wrote:
> > Since the code re-uses these constants in a few places, give them
> > kMagicPointerFoo names.
> > 
> > Also, I might not use that value; it's kind of gross. Maybe 0xdeadbadd.
> 
> What's the policy when it's just a move of a file? None of this part is
actually
> my code, I just moved it from one location to another so that PPAPI could use
> it.

just update the code at both locations, looks like a search/replace in that file
alone will suffice.

[forshaw, 2015-09-14 13:45:21]

Updated to work with latest revision and made minor changes from review. PTAL.

[jam, 2015-09-14 19:12:14]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2015-09-14 19:12:14]

lgtm with comment

https://codereview.chromium.org/1326623002/diff/40001/content/common/render_f...
File content/common/render_font_warmup_win.h (right):

https://codereview.chromium.org/1326623002/diff/40001/content/common/render_f...
content/common/render_font_warmup_win.h:5: #ifndef
CONTENT_COMMON_RENDER_FONT_WARMUP_WIN_H_
i'd get rid of "Render" from file name. i.e. content/common/font_warmup_win.h
since this file isn't renderer process specific anymore

[forshaw, 2015-09-14 19:41:09]

On 2015/09/14 19:12:14, jam wrote:
> lgtm with comment
> 
>
https://codereview.chromium.org/1326623002/diff/40001/content/common/render_f...
> File content/common/render_font_warmup_win.h (right):
> 
>
https://codereview.chromium.org/1326623002/diff/40001/content/common/render_f...
> content/common/render_font_warmup_win.h:5: #ifndef
> CONTENT_COMMON_RENDER_FONT_WARMUP_WIN_H_
> i'd get rid of "Render" from file name. i.e. content/common/font_warmup_win.h
> since this file isn't renderer process specific anymore

Thanks, I'll rename the files and commit.

[forshaw, 2015-09-14 21:22:02]

The CQ bit was checked by forshaw@chromium.org

[forshaw, 2015-09-14 21:22:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1326623002/#ps100001
(title: "Removed unused entries.")

[commit-bot: I haz the power, 2015-09-14 21:24:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1326623002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1326623002/100001

[commit-bot: I haz the power, 2015-09-14 21:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 21:42:49]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2015-09-14 21:50:57]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-09-14 21:50:58]

lgtm

[forshaw, 2015-09-14 21:51:56]

The CQ bit was checked by forshaw@chromium.org

[commit-bot: I haz the power, 2015-09-14 21:53:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1326623002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1326623002/100001

[commit-bot: I haz the power, 2015-09-14 22:56:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 22:56:22]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[forshaw, 2015-09-14 22:59:54]

The CQ bit was checked by forshaw@chromium.org

[commit-bot: I haz the power, 2015-09-14 23:04:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1326623002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1326623002/100001

[commit-bot: I haz the power, 2015-09-15 00:05:46]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-09-15 00:06:59]

Patchset 6 (id:??) landed as
https://crrev.com/98e2c9d0ab8df5447042c4884dad40910d1c8aa2
Cr-Commit-Position: refs/heads/master@{#348779}

[commit-bot: I haz the power, 2015-09-23 12:39:45]

Patchset 6 (id:??) landed as
https://crrev.com/98e2c9d0ab8df5447042c4884dad40910d1c8aa2
Cr-Commit-Position: refs/heads/master@{#348779}