Issue 1326593002: Fix plugins' mixed content status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1326593002: Fix plugins' mixed content status. (Closed)

Created:
5 years, 3 months ago by Mike West

Modified:
5 years, 3 months ago

Reviewers:
jschuh

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, tyoshino+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix plugins' mixed content status. https://codereview.chromium.org/1265953002/ contained a typo which moved all 'plugin' content to blockable mixed content. It should have been slightly more selective. Oops. :( BUG=513163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201553

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/loader/MixedContentChecker.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mike West

Hey Justin, mind taking a look at this? Looks like my initial patch was a ...

5 years, 3 months ago (2015-09-01 08:06:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326593002/1

5 years, 3 months ago (2015-09-01 11:34:00 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-01 12:29:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201553

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages