Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1326563003: (DO NOT LAND) Use roundOut() rather than round() to round glyph bounds in simple path

Created:
5 years, 3 months ago by kojii
Modified:
5 years, 3 months ago
Reviewers:
eae, jbroman
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use roundOut() rather than round() to round glyph bounds in simple path This patch changes round() to roundOut() to round glyph bounds to avoid possible rendering outside of the visual overflow rect. It was pointed out in a review comment[1] by jbroman, confirmed by this patch fixed fast/block/lineboxcontain/glyphs-clipping.html. Complex path has the same fix in the CL[1]. [1] https://codereview.chromium.org/1316843005/#msg5 BUG=452914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kojii
eae@, jbroman@, WDYT? The roundOut for simple path changes a good number of results only ...
5 years, 3 months ago (2015-09-01 17:46:58 UTC) #2
eae
Not sure it's worth it, how long do we expect to keep the simple path ...
5 years, 3 months ago (2015-09-01 17:55:01 UTC) #3
kojii
On 2015/09/01 17:55:01, eae wrote: > Not sure it's worth it, how long do we ...
5 years, 3 months ago (2015-09-02 01:10:53 UTC) #4
eae
5 years, 3 months ago (2015-09-02 01:13:16 UTC) #5
Agreed.

I'm not opposed to it but doubt it's worth the effort. If someone feels strongly
about it and is willing to do the work to update the test results then by all
means, go for it.

Powered by Google App Engine
This is Rietveld 408576698