Source/web/ContextMenuClientImpl.cpp - Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-01T10:55:04 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index 697b4dadbb111c6a9c7ed0bd4e10f45fb087ab89..78cbdb6c745aa549d73d773886c5052630ea6d63 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -129,7 +129,7 @@ static String selectMisspelledWord(LocalFrame* selectedFrame)

HitTestResult hitTestResult = selectedFrame->eventHandler().

hitTestResultAtPoint(selectedFrame->page()->contextMenuController().hitTestResult().pointInInnerNodeFrame());

Node* innerNode = hitTestResult.innerNode();

- VisiblePosition pos(innerNode->layoutObject()->positionForPoint(

+ VisiblePosition pos = visiblePositionOf(innerNode->layoutObject()->positionForPoint(

hitTestResult.localPoint()));

if (pos.isNull())

« no previous file with comments | « Source/core/testing/Internals.cpp ('k') | Source/web/WebSurroundingText.cpp » ('j') | no next file with comments »