Add the task to resolve function bodies

Add the task to resolve function bodies

R=leafp@google.com, paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/b0b97813f3a54fbde46f2405a9657d493e542e3b

[Brian Wilkerson, 2015-09-02 15:57:56]

brianwilkerson@google.com changed reviewers:
+ leafp@google.com, paulberry@google.com

[Brian Wilkerson, 2015-09-02 15:57:56]

There are still issues to be resolved (such as not resolving function bodies
twice and getting the right set of errors), but this finishes plumbing in the
new tasks.

[Paul Berry, 2015-09-02 17:10:08]

lgtm

https://codereview.chromium.org/1326553003/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1326553003/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:351: final
ListResultDescriptor<AnalysisError> RESOLVE_REFERENCES_ERRORS =
It looks like this result descriptor is not needed anymore.  Can we delete it?

https://codereview.chromium.org/1326553003/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2607: List<List<AnalysisError>>
perVariableErrors = getRequiredInput(INFER_STATIC_VARIABLE_ERRORS_INPUT);
Long line.  Did you forget to run the formatter?

https://codereview.chromium.org/1326553003/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:3612: class ResolveUnitReferencesTask
extends SourceBasedAnalysisTask {
I think we can delete this task too.

https://codereview.chromium.org/1326553003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/1326553003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:60: // 
runReflectiveTests(ResolveUnitReferencesTaskTest);
I'd prefer to delete this as well (and delete the corresponding class) rather
than commenting it out and leaving dead code in the code base.  We can always
recover it from source control later if necessary.

[Leaf, 2015-09-02 20:39:50]

lgtm

[Brian Wilkerson, 2015-09-03 15:08:37]

https://codereview.chromium.org/1326553003/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1326553003/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:351: final
ListResultDescriptor<AnalysisError> RESOLVE_REFERENCES_ERRORS =
> It looks like this result descriptor is not needed anymore.  Can we delete it?

Yes. I guess I should have said so in the CL's message, but I was planning on
doing clean-up in a separate CL.

https://codereview.chromium.org/1326553003/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2607: List<List<AnalysisError>>
perVariableErrors = getRequiredInput(INFER_STATIC_VARIABLE_ERRORS_INPUT);
> Long line.  Did you forget to run the formatter?

It appears so, yes.

[Brian Wilkerson, 2015-09-03 15:08:58]

Committed patchset #1 (id:1) manually as
b0b97813f3a54fbde46f2405a9657d493e542e3b (presubmit successful).