Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: net/spdy/spdy_test_util_common.cc

Issue 1326503003: Added a net::BidirectionalStream to expose a bidirectional streaming interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Matt's comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_test_util_common.cc
diff --git a/net/spdy/spdy_test_util_common.cc b/net/spdy/spdy_test_util_common.cc
index 8225d0aa7de63483a874ee042e64ee4f8776655e..116f00ff97bf85220c8fbff48bcd321c2235eb63 100644
--- a/net/spdy/spdy_test_util_common.cc
+++ b/net/spdy/spdy_test_util_common.cc
@@ -953,12 +953,23 @@ SpdyFrame* SpdyTestUtil::ConstructSpdyGet(const char* const extra_headers[],
int stream_id,
RequestPriority request_priority,
bool direct) {
+ return ConstructSpdyGet(extra_headers, extra_header_count, compressed,
+ stream_id, request_priority, direct, true);
+}
+
+SpdyFrame* SpdyTestUtil::ConstructSpdyGet(const char* const extra_headers[],
+ int extra_header_count,
+ bool compressed,
+ int stream_id,
+ RequestPriority request_priority,
+ bool direct,
+ bool fin) {
SpdyHeaderBlock block;
MaybeAddVersionHeader(&block);
block[GetMethodKey()] = "GET";
AddUrlToHeaderBlock(default_url_.spec(), &block);
AppendToHeaderBlock(extra_headers, extra_header_count, &block);
- return ConstructSpdySyn(stream_id, block, request_priority, compressed, true);
+ return ConstructSpdySyn(stream_id, block, request_priority, compressed, fin);
}
SpdyFrame* SpdyTestUtil::ConstructSpdyConnect(
@@ -1100,7 +1111,15 @@ SpdyFrame* SpdyTestUtil::ConstructSpdyPushHeaders(
SpdyFrame* SpdyTestUtil::ConstructSpdyHeaderFrame(int stream_id,
const char* const headers[],
int header_count) {
+ return ConstructSpdyHeaderFrame(stream_id, headers, header_count, false);
+}
+
+SpdyFrame* SpdyTestUtil::ConstructSpdyHeaderFrame(int stream_id,
+ const char* const headers[],
+ int header_count,
+ bool fin) {
SpdyHeadersIR spdy_headers(stream_id);
+ spdy_headers.set_fin(fin);
AppendToHeaderBlock(headers, header_count,
spdy_headers.mutable_header_block());
return CreateFramer(false)->SerializeFrame(spdy_headers);
@@ -1225,7 +1244,7 @@ SpdyFrame* SpdyTestUtil::ConstructSpdyPostSynReply(
const char* const extra_headers[],
int extra_header_count) {
// TODO(jgraettinger): Remove this method.
- return ConstructSpdyGetSynReply(NULL, 0, 1);
+ return ConstructSpdyGetSynReply(extra_headers, extra_header_count, 1);
}
SpdyFrame* SpdyTestUtil::ConstructSpdyBodyFrame(int stream_id, bool fin) {
« net/spdy/bidirectional_stream_spdy_job.cc ('K') | « net/spdy/spdy_test_util_common.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698