Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: net/http/bidirectional_stream.h

Issue 1326503003: Added a net::BidirectionalStream to expose a bidirectional streaming interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Misha's comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/bidirectional_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/bidirectional_stream.h
diff --git a/net/http/bidirectional_stream.h b/net/http/bidirectional_stream.h
new file mode 100644
index 0000000000000000000000000000000000000000..9153434cd54d70378a164fba7377aacc282c2320
--- /dev/null
+++ b/net/http/bidirectional_stream.h
@@ -0,0 +1,157 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_HTTP_BIDIRECTIONAL_STREAM_H_
+#define NET_HTTP_BIDIRECTIONAL_STREAM_H_
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "net/base/request_priority.h"
+#include "net/http/bidirectional_stream_job.h"
+#include "net/http/http_stream_factory.h"
+#include "net/ssl/ssl_config.h"
+
+namespace net {
+
+class BoundNetLog;
+class HttpAuthController;
+class HttpNetworkSession;
+class HttpStream;
+class HttpStreamRequest;
+class IOBuffer;
+class ProxyInfo;
+struct HttpRequestInfo;
+
+// A class to do HTTP/2 bidirectional streaming. Note that only one
+// ReadData or SendData should be in flight until the operation completes
+// synchronously or asynchronously. The BidirectionalStream must be torn down
+// before the HttpNetworkSession.
+class NET_EXPORT BidirectionalStream : public BidirectionalStreamJob::Delegate,
+ public HttpStreamRequest::Delegate {
+ public:
+ // Delegate interface to get notified of success of failure. Callbacks will be
+ // invoked asynchronously.
+ // TODO(xunjieli): Surface the protocol negotiated.
+ class NET_EXPORT Delegate {
+ public:
+ Delegate() {}
+
+ // Called when an error occurs. E.g. when a connection to the server cannot
+ // be established.
+ virtual void OnFailed(Error error) = 0;
+
+ // Called when the request headers have been sent.
+ virtual void OnRequestHeadersSent() = 0;
+
+ // Called when response headers are received.
+ virtual void OnHeaders(const SpdyHeaderBlock& response_headers) = 0;
+
+ // Called when read is completed asynchronously. |bytes_read| specifies how
+ // much data is available.
+ virtual void OnReadCompleted(int bytes_read) = 0;
+
+ // Called when the entire buffer passed through SendData is sent.
+ virtual void OnDataSent() = 0;
+
+ // Called when trailers are received.
+ virtual void OnTrailers(const SpdyHeaderBlock& trailers) = 0;
+
+ // Called when the stream is closed. No other delegate functions will be
+ // called after this. |status| is a net error code or OK.
mef 2015/11/24 20:03:40 If |status| is a net error code, then how is it di
xunjieli 2015/11/25 16:58:58 Done. Good point. I think we should combine these
+ virtual void OnClose(int status) = 0;
+
+ protected:
+ virtual ~Delegate() {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(Delegate);
+ };
+
+ // Parts of |request_info| are ignored (e.g. |upload_data_stream| and most
+ // load flags).
+ BidirectionalStream(const HttpRequestInfo& request_info,
+ RequestPriority priority,
+ HttpNetworkSession* session,
+ Delegate* delegate);
+
+ // Destroys the helper and cancels any pending request.
+ ~BidirectionalStream() override;
+
+ // Reads at most |buf_len| bytes into |buf|. Returns the number of bytes read,
+ // or ERR_IO_PENDING if the read is to be completed asynchronously.
+ // There should not be called again unless it IO completes synchronously or
+ // until OnReadCompleted is invoked.
+ int ReadData(IOBuffer* buf, int buf_len);
+
+ // Sends data. This should not be called again until OnDataSent is invoked.
+ void SendData(IOBuffer* data, int length, bool end_stream);
+
+ // If there is |stream_request_|, cancel it. If |stream_job_| is established,
+ // cancel it.
+ void Cancel();
+
+ // TODO(xunjieli): implement a method to do flow control, and a method to ping
+ // remote end point.
+
+ private:
+ // BidirectionalStreamJob::Delegate implementation:
+
+ void OnFailed(Error error) override;
+
+ void OnRequestHeadersSent() override;
+
+ void OnHeaders(const SpdyHeaderBlock& response_headers) override;
+
+ void OnReadCompleted(int bytes_read) override;
+
+ void OnDataSent() override;
+
+ void OnTrailers(const SpdyHeaderBlock& trailers) override;
+
+ void OnClose(int status) override;
+
+ // HttpStreamRequest::Delegate implementation:
+
+ void OnStreamReady(const SSLConfig& used_ssl_config,
+ const ProxyInfo& used_proxy_info,
+ HttpStream* stream) override;
+ void OnBidirectionalStreamJobReady(const SSLConfig& used_ssl_config,
+ const ProxyInfo& used_proxy_info,
+ BidirectionalStreamJob* stream) override;
+ void OnWebSocketHandshakeStreamReady(
+ const SSLConfig& used_ssl_config,
+ const ProxyInfo& used_proxy_info,
+ WebSocketHandshakeStreamBase* stream) override;
+ void OnStreamFailed(int status,
+ const SSLConfig& used_ssl_config,
+ SSLFailureState ssl_failure_state) override;
+ void OnCertificateError(int status,
+ const SSLConfig& used_ssl_config,
+ const SSLInfo& ssl_info) override;
+ void OnNeedsProxyAuth(const HttpResponseInfo& response_info,
+ const SSLConfig& used_ssl_config,
+ const ProxyInfo& used_proxy_info,
+ HttpAuthController* auth_controller) override;
+ void OnNeedsClientAuth(const SSLConfig& used_ssl_config,
+ SSLCertRequestInfo* cert_info) override;
+ void OnHttpsProxyTunnelResponse(const HttpResponseInfo& response_info,
+ const SSLConfig& used_ssl_config,
+ const ProxyInfo& used_proxy_info,
+ HttpStream* stream) override;
+
+ const HttpRequestInfo request_info_;
+ RequestPriority priority_;
+ BoundNetLog net_log_;
+
+ Delegate* delegate_;
+
+ scoped_ptr<HttpStreamRequest> stream_request_;
+ scoped_ptr<BidirectionalStreamJob> stream_job_;
+
+ DISALLOW_COPY_AND_ASSIGN(BidirectionalStream);
+};
+
+} // namespace net
+
+#endif // NET_HTTP_BIDIRECTIONAL_STREAM_H_
« no previous file with comments | « no previous file | net/http/bidirectional_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698