Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: net/http/bidirectional_stream_unittest.cc

Issue 1326503003: Added a net::BidirectionalStream to expose a bidirectional streaming interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/bidirectional_stream_unittest.cc
diff --git a/net/http/bidirectional_stream_unittest.cc b/net/http/bidirectional_stream_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bdca2ddacd9c9d3675842a938a58e9a571226737
--- /dev/null
+++ b/net/http/bidirectional_stream_unittest.cc
@@ -0,0 +1,233 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/http/bidirectional_stream.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "base/run_loop.h"
+#include "base/strings/string_piece.h"
+#include "net/base/net_errors.h"
+#include "net/base/test_data_directory.h"
+#include "net/http/http_network_session.h"
+#include "net/http/http_request_info.h"
+#include "net/http/http_response_headers.h"
+#include "net/log/net_log.h"
+#include "net/socket/socket_test_util.h"
+#include "net/spdy/spdy_session.h"
+#include "net/spdy/spdy_test_util_common.h"
+#include "net/spdy/spdy_test_util_common.h"
+#include "net/test/cert_test_util.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+namespace {
+
+const char kBodyData[] = "Body data";
+const size_t kBodyDataSize = arraysize(kBodyData);
+const base::StringPiece kBodyDataStringPiece(kBodyData, kBodyDataSize);
+// Size of the buffer to be allocated for each read.
+const size_t kReadBufferSize = 4096;
+
+class TestBidirectionalStreamDelegate : public BidirectionalStream::Delegate {
+ public:
+ TestBidirectionalStreamDelegate(IOBuffer* read_buf, int read_buf_len)
+ : error_code_(OK),
+ bytes_read_(0),
+ close_status_(ERR_FAILED),
+ read_buf_(read_buf),
+ read_buf_len_(read_buf_len) {}
+
+ ~TestBidirectionalStreamDelegate() override {}
+
+ void OnFailed(Error error) override {
+ error_code_ = error;
+ loop_.Quit();
+ }
+
+ void OnRequestHeadersSent() override {}
+
+ void OnHeaders(const SpdyHeaderBlock& response_headers) override {
+ response_headers_ = response_headers;
+ StartOrContinueReading();
+ }
+
+ void OnReadCompleted(int bytes_read) override {
+ CHECK_GT(bytes_read, OK);
+ bytes_read_ += bytes_read;
+ data_received_.append(read_buf_->data(), bytes_read_);
+ StartOrContinueReading();
+ }
+
+ void OnDataSent() override {}
+
+ void OnTrailers(const SpdyHeaderBlock& trailers) override {
+ trailers_ = trailers;
+ }
+
+ void OnClose(int status) override {
+ close_status_ = status;
+ loop_.Quit();
+ }
+
+ void CreateBidirectionalStream(const HttpRequestInfo& request_info,
+ RequestPriority priority,
+ HttpNetworkSession* session) {
+ stream_.reset(
+ new BidirectionalStream(request_info, priority, session, this));
+ loop_.Run();
+ }
+
+ void SendData(IOBuffer* data, int length, bool end_of_stream) {
+ stream_->SendData(data, length, end_of_stream);
+ }
+
+ const std::string& data_received() const { return data_received_; }
+
+ int error_code_;
+ SpdyHeaderBlock response_headers_;
+ SpdyHeaderBlock trailers_;
+ int bytes_read_;
+ int close_status_;
+
+ private:
+ void StartOrContinueReading() {
+ int rv = stream_->ReadData(read_buf_.get(), read_buf_len_);
+ while (rv > 0) {
+ bytes_read_ += rv;
+ data_received_.append(read_buf_->data(), rv);
+ rv = stream_->ReadData(read_buf_.get(), read_buf_len_);
+ }
+ }
+
+ scoped_refptr<IOBuffer> read_buf_;
+ int read_buf_len_;
+ std::string data_received_;
+ base::RunLoop loop_;
+ scoped_ptr<BidirectionalStream> stream_;
+};
+
+// A delegate that sends data after request headers are sent.
+class SendDataDelegate : public TestBidirectionalStreamDelegate {
+ public:
+ SendDataDelegate(IOBuffer* buf, int buf_len, base::StringPiece data)
+ : TestBidirectionalStreamDelegate(buf, buf_len), data_(data) {}
+
+ ~SendDataDelegate() override {}
+
+ void OnRequestHeadersSent() override {
+ TestBidirectionalStreamDelegate::OnRequestHeadersSent();
+ if (data_.data()) {
+ scoped_refptr<StringIOBuffer> buf(new StringIOBuffer(data_.as_string()));
+ SendData(buf.get(), buf->size(), NO_MORE_DATA_TO_SEND);
+ }
+ }
+
+ private:
+ base::StringPiece data_;
+};
+
+class BidirectionalStreamTest : public testing::Test {
+ public:
+ BidirectionalStreamTest()
+ : spdy_util_(kProtoHTTP2), session_deps_(kProtoHTTP2) {}
+
+ protected:
+ // Initializes the session using SequencedSocketData.
+ void InitSession(MockRead* reads,
+ size_t reads_count,
+ MockWrite* writes,
+ size_t writes_count,
+ const SpdySessionKey& key) {
+ sequenced_data_.reset(
+ new SequencedSocketData(reads, reads_count, writes, writes_count));
+ session_deps_.socket_factory->AddSocketDataProvider(sequenced_data_.get());
+ http_session_ = SpdySessionDependencies::SpdyCreateSession(&session_deps_);
+ session_ = CreateSecureSpdySession(http_session_.get(), key, BoundNetLog());
+ }
+
+ SpdyTestUtil spdy_util_;
+ SpdySessionDependencies session_deps_;
+ scoped_ptr<SequencedSocketData> sequenced_data_;
+ scoped_ptr<HttpNetworkSession> http_session_;
+ base::WeakPtr<SpdySession> session_;
+};
+
+} // namespace
+
+TEST_F(BidirectionalStreamTest, CreateInsecureStream) {
+ HttpRequestInfo request;
+ request.method = "GET";
+ request.url = GURL("http://www.example.org/");
+
+ TestBidirectionalStreamDelegate delegate(nullptr, 0);
+ HttpNetworkSession::Params params =
+ SpdySessionDependencies::CreateSessionParams(&session_deps_);
+ scoped_ptr<HttpNetworkSession> session(new HttpNetworkSession(params));
+ delegate.CreateBidirectionalStream(request, LOWEST, session.get());
+ EXPECT_EQ(ERR_DISALLOWED_URL_SCHEME, delegate.error_code_);
+}
+
+TEST_F(BidirectionalStreamTest, SendPostRequest) {
+ spdy_util_.set_default_url(GURL("https://www.example.org"));
+ BufferedSpdyFramer framer(spdy_util_.spdy_version(), false);
+
+ scoped_ptr<SpdyFrame> req(spdy_util_.ConstructChunkedSpdyPost(NULL, 0));
+ scoped_ptr<SpdyFrame> body(
+ framer.CreateDataFrame(1, kBodyData, kBodyDataSize, DATA_FLAG_FIN));
+ MockWrite writes[] = {
+ CreateMockWrite(*req, 0), // request
+ CreateMockWrite(*body, 1), // POST upload frame
+ };
+ const char* const kExtraResponseHeaders[] = {"header-name", "header-value"};
+ scoped_ptr<SpdyFrame> resp(
+ spdy_util_.ConstructSpdyPostSynReply(kExtraResponseHeaders, 1));
+
+ scoped_ptr<SpdyFrame> resp_data(
+ framer.CreateDataFrame(1, kBodyData, kBodyDataSize, DATA_FLAG_NONE));
+
+ const char* const kExtraHeaders[] = {"foo", "bar"};
+ scoped_ptr<SpdyFrame> trailers(
+ spdy_util_.ConstructSpdyHeaderFrame(1, kExtraHeaders, 1, true));
+
+ MockRead reads[] = {
+ CreateMockRead(*resp, 2), CreateMockRead(*resp_data, 3),
+ CreateMockRead(*trailers, 4), MockRead(SYNCHRONOUS, 0, 5) // EOF
+ };
+
+ HostPortPair host_port_pair("www.example.org", 443);
+ SpdySessionKey key(host_port_pair, ProxyServer::Direct(),
+ PRIVACY_MODE_DISABLED);
+
+ SSLSocketDataProvider ssl_data(ASYNC, OK);
+ ssl_data.SetNextProto(kProtoHTTP2);
+ ssl_data.cert = ImportCertFromFile(GetTestCertsDirectory(), "ok_cert.pem");
+ ASSERT_TRUE(ssl_data.cert.get());
+ session_deps_.socket_factory->AddSSLSocketDataProvider(&ssl_data);
+
+ InitSession(reads, arraysize(reads), writes, arraysize(writes), key);
+
+ HttpRequestInfo request;
+ request.method = "POST";
+ request.url = GURL("https://www.example.org/");
+
+ scoped_refptr<IOBuffer> read_buffer(new IOBuffer(kReadBufferSize));
+ scoped_ptr<TestBidirectionalStreamDelegate> delegate(new SendDataDelegate(
+ read_buffer.get(), kReadBufferSize, kBodyDataStringPiece));
+ delegate->CreateBidirectionalStream(request, DEFAULT_PRIORITY,
+ http_session_.get());
+
+ base::StringPiece header = delegate->response_headers_[":status"];
+ EXPECT_EQ("200", header);
+ base::StringPiece extra_header = delegate->response_headers_["header-name"];
+ EXPECT_EQ("header-value", extra_header);
+ EXPECT_EQ((int)kBodyDataSize, delegate->bytes_read_);
+ EXPECT_EQ(std::string(kBodyData, kBodyDataSize), delegate->data_received());
+ base::StringPiece trailer = delegate->trailers_["foo"];
+ EXPECT_EQ("bar", trailer);
+ EXPECT_EQ(OK, delegate->close_status_);
+}
+
+} // namespace net

Powered by Google App Engine
This is Rietveld 408576698