Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: net/spdy/spdy_test_util_common.cc

Issue 1326503003: Added a net::BidirectionalStream to expose a bidirectional streaming interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use std::move Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/net.gypi ('K') | « net/spdy/spdy_test_util_common.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_test_util_common.cc
diff --git a/net/spdy/spdy_test_util_common.cc b/net/spdy/spdy_test_util_common.cc
index 8225d0aa7de63483a874ee042e64ee4f8776655e..4c65a4b8e8032406cb65b9969ae194a7a07f1ef9 100644
--- a/net/spdy/spdy_test_util_common.cc
+++ b/net/spdy/spdy_test_util_common.cc
@@ -1100,7 +1100,15 @@ SpdyFrame* SpdyTestUtil::ConstructSpdyPushHeaders(
SpdyFrame* SpdyTestUtil::ConstructSpdyHeaderFrame(int stream_id,
const char* const headers[],
int header_count) {
+ return ConstructSpdyHeaderFrame(stream_id, headers, header_count, false);
+}
+
+SpdyFrame* SpdyTestUtil::ConstructSpdyHeaderFrame(int stream_id,
+ const char* const headers[],
+ int header_count,
+ bool fin) {
SpdyHeadersIR spdy_headers(stream_id);
+ spdy_headers.set_fin(fin);
AppendToHeaderBlock(headers, header_count,
spdy_headers.mutable_header_block());
return CreateFramer(false)->SerializeFrame(spdy_headers);
@@ -1225,7 +1233,7 @@ SpdyFrame* SpdyTestUtil::ConstructSpdyPostSynReply(
const char* const extra_headers[],
int extra_header_count) {
// TODO(jgraettinger): Remove this method.
- return ConstructSpdyGetSynReply(NULL, 0, 1);
+ return ConstructSpdyGetSynReply(extra_headers, extra_header_count, 1);
mef 2015/12/21 17:31:43 why this changed?
xunjieli 2015/12/21 22:01:22 I was trying to test setting extra headers on the
mef 2015/12/21 23:21:31 Acknowledged.
}
SpdyFrame* SpdyTestUtil::ConstructSpdyBodyFrame(int stream_id, bool fin) {
« net/net.gypi ('K') | « net/spdy/spdy_test_util_common.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698