Added a net::BidirectionalStream to expose a bidirectional streaming interface

net/spdy/bidirectional_stream_spdy_job.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_SPDY_BIDIRECTIONAL_STREAM_SPDY_JOB_H_
+#define NET_SPDY_BIDIRECTIONAL_STREAM_SPDY_JOB_H_
+
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "net/http/bidirectional_stream_job.h"
+#include "net/http/http_request_info.h"
+#include "net/spdy/spdy_read_queue.h"
+#include "net/spdy/spdy_session.h"
+#include "net/spdy/spdy_stream.h"
+
+namespace base {
+class Timer;
+}  // namespace base
+
+namespace net {
+
+class BoundNetLog;
+class IOBuffer;
+class SpdyHeaderBlock;
+
+class NET_EXPORT_PRIVATE BidirectionalStreamSpdyJob
+    : public BidirectionalStreamJob,
+      public SpdyStream::Delegate {
+ public:
+  BidirectionalStreamSpdyJob(const base::WeakPtr<SpdySession>& spdy_session);

[mmenke, 2015/12/11 22:19:59]

explicit

[xunjieli, 2015/12/11 23:48:41]

Done.

+
+  // Constructor that accepts a Timer. This is used in tests.
+  BidirectionalStreamSpdyJob(const base::WeakPtr<SpdySession>& spdy_session,
+                             scoped_ptr<base::Timer> timer);

[mmenke, 2015/12/11 22:19:59]

Mention what the timer does?

[xunjieli, 2015/12/11 23:48:41]

Done.

+  ~BidirectionalStreamSpdyJob() override;

[mmenke, 2015/12/11 22:19:59]

Seems weird to have a line break between the two constructions, but not the
second constructor and the destructor.

[xunjieli, 2015/12/11 23:48:41]

Done.

+
+  // BidirectionalStreamSpdyJob implementation:
+
+  void Start(const HttpRequestInfo& request_info,
+             RequestPriority priority,
+             const BoundNetLog& net_log,
+             BidirectionalStreamJob::Delegate* delegate) override;
+
+  int ReadData(IOBuffer* buf, int buf_len) override;
+
+  void SendData(IOBuffer* data, int length, bool end_stream) override;
+
+  void Cancel() override;
+
+  NextProto GetProtocol() const override;
+
+  int64_t GetTotalReceivedBytes() const override;
+
+  int64_t GetTotalSentBytes() const override;
+
+  // SpdyStream::Delegate implementation:
+
+  void OnRequestHeadersSent() override;
+
+  SpdyResponseHeadersStatus OnResponseHeadersUpdated(
+      const SpdyHeaderBlock& response_headers) override;
+
+  void OnDataReceived(scoped_ptr<SpdyBuffer> buffer) override;
+
+  void OnDataSent() override;
+
+  void OnTrailers(const SpdyHeaderBlock& trailers) override;
+
+  void OnClose(int status) override;

[mmenke, 2015/12/11 22:19:59]

Generally no blank lines are put between different methods that implement the
same parent class.  Not universally done, but often enough that I, at least,
have grown used to it.

[xunjieli, 2015/12/11 23:48:41]

Done.

+
+ private:
+  void SendRequestHeaders();
+  void OnStreamInitialized(int rv);
+  void ScheduleBufferedRead();
+  void DoBufferedRead();
+  bool ShouldWaitForMoreBufferedData() const;
+
+  const base::WeakPtr<SpdySession> spdy_session_;
+  scoped_ptr<base::Timer> timer_;
+  bool stream_closed_;
+  int closed_stream_status_;
+  bool more_read_data_pending_;
+
+  HttpRequestInfo request_info_;
+  // Buffers the data as it arrives asynchronously from the stream.
+  SpdyReadQueue data_queue_;
+  // User provided buffer for ReadData() response.
+  scoped_refptr<IOBuffer> user_buffer_;
+  int user_buffer_len_;

[mmenke, 2015/12/11 22:19:59]

read_buffer_ / read_buffer_len_?

[xunjieli, 2015/12/11 23:48:41]

Done.

+
+  BidirectionalStreamJob::Delegate* delegate_;
+  SpdyStreamRequest stream_request_;
+  base::WeakPtr<SpdyStream> stream_;
+  NextProto negotiated_protocol_;
+  // After |stream_| has been closed, this keeps track of the total number of
+  // bytes received over the network for |stream_| while it was open.
+  int64_t closed_stream_received_bytes_;
+  // After |stream_| has been closed, this keeps track of the total number of
+  // bytes sent over the network for |stream_| while it was open.
+  int64_t closed_stream_sent_bytes_;

[mmenke, 2015/12/11 22:19:59]

include <stdint.h>

[xunjieli, 2015/12/11 23:48:41]

Done.

+
+  base::WeakPtrFactory<BidirectionalStreamSpdyJob> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(BidirectionalStreamSpdyJob);
+};
+
+}  // namespace net
+
+#endif  // NET_SPDY_BIDIRECTIONAL_STREAM_SPDY_JOB_H_