Added a net::BidirectionalStream to expose a bidirectional streaming interface

net/http/http_stream_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_FACTORY_H_
 #define NET_HTTP_HTTP_STREAM_FACTORY_H_
 
 #include <list>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string16.h"
 #include "net/base/completion_callback.h"
 #include "net/base/load_states.h"
 #include "net/base/net_export.h"
 #include "net/base/request_priority.h"
+#include "net/http/bidirectional_stream_job.h"

[xunjieli, 2015/12/21 22:01:22]

Had to add this because otherwise when HttpStreamFactoryImpl job import this
file, it complains that it cannot determine the size of the forward declared
BidirectionalStreamJob class.

WebSocket did the same on line 25, even though the file is included in websocket
sources.

[mef, 2015/12/21 23:21:31]

Yeah, I'm not sure why this is happening. It also compiles if I forward-declare
it here and unconditionally #include "net/http/bidirectional_stream_job.h" into
http_stream_factory_impl_job.cc.

[xunjieli, 2015/12/22 02:58:48]

Acknowledged.

 #include "net/http/http_server_properties.h"
 #include "net/socket/connection_attempts.h"
 #include "net/ssl/ssl_failure_state.h"
 // This file can be included from net/http even though
 // it is in net/websockets because it doesn't
 // introduce any link dependency to net/websockets.
 #include "net/websockets/websocket_handshake_stream_base.h"
 
 class GURL;
 
@@ skipping 49 matching lines @@
     // |used_ssl_config| indicates the actual SSL configuration used for this
     // stream, since the HttpStreamRequest may have modified the configuration
     // during stream processing.
     // |used_proxy_info| indicates the actual ProxyInfo used for this stream,
     // since the HttpStreamRequest performs the proxy resolution.
     virtual void OnWebSocketHandshakeStreamReady(
         const SSLConfig& used_ssl_config,
         const ProxyInfo& used_proxy_info,
         WebSocketHandshakeStreamBase* stream) = 0;
 
+    virtual void OnBidirectionalStreamJobReady(
+        const SSLConfig& used_ssl_config,
+        const ProxyInfo& used_proxy_info,
+        BidirectionalStreamJob* stream) = 0;
+
     // This is the failure to create a stream case.
     // |used_ssl_config| indicates the actual SSL configuration used for this
     // stream, since the HttpStreamRequest may have modified the configuration
     // during stream processing. If an SSL handshake failed, |ssl_failure_state|
     // is the state the SSLClientSocket was in.
     virtual void OnStreamFailed(int status,
                                 const SSLConfig& used_ssl_config,
                                 SSLFailureState ssl_failure_state) = 0;
 
     // Called when we have a certificate error for the request.
@@ skipping 122 matching lines @@
   // completion.
   virtual HttpStreamRequest* RequestWebSocketHandshakeStream(
       const HttpRequestInfo& info,
       RequestPriority priority,
       const SSLConfig& server_ssl_config,
       const SSLConfig& proxy_ssl_config,
       HttpStreamRequest::Delegate* delegate,
       WebSocketHandshakeStreamBase::CreateHelper* create_helper,
       const BoundNetLog& net_log) = 0;
 
+  // Request a BidirectionalStreamJob.
+  // Will call delegate->OnBidirectionalStreamJobReady on successful
+  // completion.
+  virtual HttpStreamRequest* RequestBidirectionalStreamJob(
+      const HttpRequestInfo& info,
+      RequestPriority priority,
+      const SSLConfig& server_ssl_config,
+      const SSLConfig& proxy_ssl_config,
+      HttpStreamRequest::Delegate* delegate,
+      const BoundNetLog& net_log) = 0;
+
   // Requests that enough connections for |num_streams| be opened.
   virtual void PreconnectStreams(int num_streams,
                                  const HttpRequestInfo& info,
                                  const SSLConfig& server_ssl_config,
                                  const SSLConfig& proxy_ssl_config) = 0;
 
   virtual const HostMappingRules* GetHostMappingRules() const = 0;
 
   // Static settings
 
@@ skipping 15 matching lines @@
   static bool spdy_enabled_;
 
   HostPortPair RewriteHost(HostPortPair host_port_pair);
 
   DISALLOW_COPY_AND_ASSIGN(HttpStreamFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_FACTORY_H_