Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1326493002: Make unsafe Unique<T> constructor private. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make unsafe Unique<T> constructor private. The constructor taking an artificial raw address was only used as a workaround in TurboFan. It should only be accessible by constructor functions internal to Unique<T>. R=titzer@chromium.org Committed: https://crrev.com/0526e102d73c3253c3ad90350d774d36758a4278 Cr-Commit-Position: refs/heads/master@{#30464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/unique.h View 3 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-31 09:51:16 UTC) #1
titzer
lgtm
5 years, 3 months ago (2015-08-31 09:55:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326493002/1
5 years, 3 months ago (2015-08-31 10:13:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 10:44:11 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 10:44:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0526e102d73c3253c3ad90350d774d36758a4278
Cr-Commit-Position: refs/heads/master@{#30464}

Powered by Google App Engine
This is Rietveld 408576698