Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1326483002: Vector ICs: Adapting store ic classes for vectors. (Closed)

Created:
5 years, 3 months ago by mvstanton
Modified:
5 years, 3 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Vector ICs: Adapting store ic classes for vectors. BUG= Committed: https://crrev.com/e1b46f7a18a403524bb81cb1bb4c1c26c8e143ea Cr-Commit-Position: refs/heads/master@{#30512}

Patch Set 1 #

Patch Set 2 : Fix windows compilation error. #

Total comments: 1

Patch Set 3 : REBASE and comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -60 lines) Patch
M src/ic/access-compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/access-compiler.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/ic/handler-compiler.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 2 4 chunks +30 lines, -6 lines 0 comments Download
M src/ic/ic.h View 3 chunks +14 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 2 15 chunks +96 lines, -17 lines 0 comments Download
M src/ic/ic-compiler.h View 2 chunks +13 lines, -2 lines 0 comments Download
M src/ic/ic-compiler.cc View 7 chunks +60 lines, -33 lines 0 comments Download
M src/type-feedback-vector.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mvstanton
Hi Igor, Here are some more adaptations for vector stores. This covers all the changes ...
5 years, 3 months ago (2015-08-31 07:46:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326483002/20001
5 years, 3 months ago (2015-08-31 13:04:01 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 13:30:04 UTC) #6
mvstanton
one kine small ping...
5 years, 3 months ago (2015-09-01 10:57:02 UTC) #7
Igor Sheludko
lgtm with a nit. https://codereview.chromium.org/1326483002/diff/20001/src/ic/handler-compiler.cc File src/ic/handler-compiler.cc (right): https://codereview.chromium.org/1326483002/diff/20001/src/ic/handler-compiler.cc#newcode513 src/ic/handler-compiler.cc:513: bool need_save_restore = As discussed ...
5 years, 3 months ago (2015-09-01 12:51:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326483002/40001
5 years, 3 months ago (2015-09-01 13:44:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-01 14:09:16 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 14:09:31 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e1b46f7a18a403524bb81cb1bb4c1c26c8e143ea
Cr-Commit-Position: refs/heads/master@{#30512}

Powered by Google App Engine
This is Rietveld 408576698