Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1730)

Issue 1326473002: X87: [runtime] Add %ToString and %_ToString and remove the TO_STRING builtin. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Add %ToString and %_ToString and remove the TO_STRING builtin. port 09de997b3504368d40644afa7310b90faff5d09c (r30442). original commit message: This adds a new ToString runtime function and a fast-path ToStringStub (which is just a simple dispatcher for existing functionality), and also implements %_ToName using the ToStringStub. R=weiliang.lin@intel.com BUG= Committed: https://crrev.com/3f6e5b3014685c90610da107193400af7f7790d4 Cr-Commit-Position: refs/heads/master@{#30460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -2 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-08-31 07:30:47 UTC) #1
Weiliang
lgtm
5 years, 3 months ago (2015-08-31 08:57:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326473002/1
5 years, 3 months ago (2015-08-31 08:58:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 09:23:25 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 09:23:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f6e5b3014685c90610da107193400af7f7790d4
Cr-Commit-Position: refs/heads/master@{#30460}

Powered by Google App Engine
This is Rietveld 408576698