Chromium Code Reviews| Index: build/config/sanitizers/sanitizers.gni |
| diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni |
| index cab01b1c45d260d73c2d99fec7c8f6d5d9538d80..a45275cc26c21cbdbff74b29cab6eb9bd812b321 100644 |
| --- a/build/config/sanitizers/sanitizers.gni |
| +++ b/build/config/sanitizers/sanitizers.gni |
| @@ -23,3 +23,17 @@ declare_args() { |
| # https://code.google.com/p/sawbuck/wiki/SyzyASanHowTo |
| is_syzyasan = false |
| } |
| + |
| +# MSan only links Chrome properly in release builds (brettw -- 9/1/2015). The |
| +# same is possibly true for the other sanitizers. But regardless of whether it |
| +# links, one would normally never run a sanitizer in release mode. Running in |
|
Nico
2015/09/01 21:59:45
"never run a sanitizer in _debug_ mode", right?
|
| +# debug mode probably indicates you forgot to set the "is_debug = false" flag |
| +# in the build args. |
| +# |
| +# If you find a use-case where you want to compile a sanitizer in debug mode |
| +# and have verified it works, you can remove it from this condition. But please |
| +# balance how common your use-case is versus how easy it is to forget to set |
| +# the release flag, have an unpleasant time trying to use the sanitizer, and |
| +# have to rebuild. For one-off builds, just comment this out locally. |
| +assert(!is_debug || !(is_msan || is_asan || is_lsan || is_tsan), |
| + "Sanitizers should generally be used in release (set is_debug=false).") |