Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1326453003: Add a assert for running a sanitizer in debug. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a assert for running a sanitizer in debug. I found that msan doesn't link in debug builds. It fails linking with an obscure error. To prevent other people from having this problem, this patch adds an assert for this case. Committed: https://crrev.com/1131f71c0604dfbe6e1f2d3ef6dcb8d288c7e4f6 Cr-Commit-Position: refs/heads/master@{#346764}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M build/config/sanitizers/sanitizers.gni View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 3 months ago (2015-09-01 21:50:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326453003/20001
5 years, 3 months ago (2015-09-01 21:51:40 UTC) #4
Nico
lgtm! https://codereview.chromium.org/1326453003/diff/20001/build/config/sanitizers/sanitizers.gni File build/config/sanitizers/sanitizers.gni (right): https://codereview.chromium.org/1326453003/diff/20001/build/config/sanitizers/sanitizers.gni#newcode29 build/config/sanitizers/sanitizers.gni:29: # links, one would normally never run a ...
5 years, 3 months ago (2015-09-01 21:59:45 UTC) #5
brettw
Good catch, thanks.
5 years, 3 months ago (2015-09-01 22:03:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326453003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326453003/40001
5 years, 3 months ago (2015-09-01 22:04:15 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-01 22:51:48 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 22:52:23 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1131f71c0604dfbe6e1f2d3ef6dcb8d288c7e4f6
Cr-Commit-Position: refs/heads/master@{#346764}

Powered by Google App Engine
This is Rietveld 408576698