Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: tools/generate_dump.cc

Issue 1326443007: win: Fix incorrect thread suspend count due to ScopedProcessSuspend (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: assert some threads captured Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/system_snapshot_win_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/generate_dump.cc
diff --git a/tools/generate_dump.cc b/tools/generate_dump.cc
index f68c17c2a068be8a356d2fb29d41a45711d11106..c68d214ac99d146a2e6e22d5137f30a83726792d 100644
--- a/tools/generate_dump.cc
+++ b/tools/generate_dump.cc
@@ -182,7 +182,10 @@ int GenerateDumpMain(int argc, char* argv[]) {
}
#elif defined(OS_WIN)
ProcessSnapshotWin process_snapshot;
- if (!process_snapshot.Initialize(process.get())) {
+ if (!process_snapshot.Initialize(process.get(),
+ options.suspend
+ ? ProcessSuspensionState::kSuspended
+ : ProcessSuspensionState::kRunning)) {
return EXIT_FAILURE;
}
#endif // OS_MACOSX
« no previous file with comments | « snapshot/win/system_snapshot_win_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698