snapshot/win/pe_image_annotations_reader_test.cc - Issue 1326443007: win: Fix incorrect thread suspend count due to ScopedProcessSuspend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/pe_image_annotations_reader_test.cc

Issue 1326443007: win: Fix incorrect thread suspend count due to ScopedProcessSuspend (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: assert some threads captured Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/win/pe_image_annotations_reader_test.cc

diff --git a/snapshot/win/pe_image_annotations_reader_test.cc b/snapshot/win/pe_image_annotations_reader_test.cc

index 383ada99e01fddf69e54796f713492d01441d88f..2c88417d0a49dd8e53c36f0fff3451aa0569748e 100644

--- a/snapshot/win/pe_image_annotations_reader_test.cc

+++ b/snapshot/win/pe_image_annotations_reader_test.cc

@@ -55,7 +55,8 @@ class TestPEImageAnnotationsReader final : public WinMultiprocess {

void WinMultiprocessParent() override {

ProcessReaderWin process_reader;

- ASSERT_TRUE(process_reader.Initialize(ChildProcess()));

+ ASSERT_TRUE(process_reader.Initialize(ChildProcess(),

+ ProcessSuspensionState::kRunning));

// Wait for the child process to indicate that it's done setting up its

// annotations via the CrashpadInfo interface.

« no previous file with comments | « snapshot/win/exception_snapshot_win_test.cc ('k') | snapshot/win/pe_image_reader_test.cc » ('j') | no next file with comments »