Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: handler/win/crash_report_exception_handler.cc

Issue 1326443007: win: Fix incorrect thread suspend count due to ScopedProcessSuspend (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: pass in state Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | snapshot/crashpad_info_client_options_test.cc » ('j') | snapshot/win/process_reader_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: handler/win/crash_report_exception_handler.cc
diff --git a/handler/win/crash_report_exception_handler.cc b/handler/win/crash_report_exception_handler.cc
index 69df244f7f9e0c5c3d81058cff57d084c6c38e79..c293cb3a94b335740e63baecf2414964eda0dd6c 100644
--- a/handler/win/crash_report_exception_handler.cc
+++ b/handler/win/crash_report_exception_handler.cc
@@ -21,7 +21,6 @@
#include "snapshot/win/process_snapshot_win.h"
#include "util/file/file_writer.h"
#include "util/win/registration_protocol_win.h"
-#include "util/win/scoped_process_suspend.h"
namespace crashpad {
@@ -45,10 +44,9 @@ unsigned int CrashReportExceptionHandler::ExceptionHandlerServerException(
WinVMAddress exception_information_address) {
const unsigned int kFailedTerminationCode = 0xffff7002;
- ScopedProcessSuspend suspend(process);
-
ProcessSnapshotWin process_snapshot;
- if (!process_snapshot.Initialize(process)) {
+ if (!process_snapshot.Initialize(process,
+ ProcessSuspensionState::kSuspended)) {
LOG(WARNING) << "ProcessSnapshotWin::Initialize failed";
return kFailedTerminationCode;
}
« no previous file with comments | « no previous file | snapshot/crashpad_info_client_options_test.cc » ('j') | snapshot/win/process_reader_win.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698