win: Fix incorrect thread suspend count due to ScopedProcessSuspend

snapshot/win/exception_snapshot_win_test.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "snapshot/win/exception_snapshot_win.h"
 
 #include <string>
 
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "client/crashpad_client.h"
 #include "gtest/gtest.h"
 #include "snapshot/win/process_snapshot_win.h"
 #include "test/win/win_child_process.h"
 #include "util/thread/thread.h"
 #include "util/win/exception_handler_server.h"
 #include "util/win/registration_protocol_win.h"
 #include "util/win/scoped_handle.h"
+#include "util/win/scoped_process_suspend.h"
 
 namespace crashpad {
 namespace test {
 namespace {
 
 HANDLE DuplicateEvent(HANDLE process, HANDLE event) {
   HANDLE handle;
   if (DuplicateHandle(GetCurrentProcess(),
                       event,
                       process,
@@ skipping 16 matching lines @@
           break_near_(nullptr) {}
     ~Delegate() override {}
 
     void set_break_near(void* break_near) { break_near_ = break_near; }
 
     void ExceptionHandlerServerStarted() override { SetEvent(server_ready_); }
 
     unsigned int ExceptionHandlerServerException(
         HANDLE process,
         WinVMAddress exception_information_address) override {
+      ScopedProcessSuspend suspend(process);
       ProcessSnapshotWin snapshot;
-      snapshot.Initialize(process);
+      snapshot.Initialize(process, ProcessSuspensionState::kSuspended);
       snapshot.InitializeException(exception_information_address);
 
       // Confirm the exception record was read correctly.
       EXPECT_NE(snapshot.Exception()->ThreadID(), 0u);
       EXPECT_EQ(snapshot.Exception()->Exception(), EXCEPTION_BREAKPOINT);
 
       // Verify the exception happened at the expected location with a bit of
       // slop space to allow for reading the current PC before the exception
       // happens. See CrashingChildProcess::Run().
       const uint64_t kAllowedOffset = 64;
@@ skipping 126 matching lines @@
       handle->read.get(), &break_near_address, sizeof(break_near_address));
   delegate.set_break_near(break_near_address);
 
   // Wait for the child to crash and the exception information to be validated.
   WaitForSingleObject(completed.get(), INFINITE);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad