Issue 132643007: Revert "Revert of https://codereview.chromium.org/129423002/"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132643007: Revert "Revert of https://codereview.chromium.org/129423002/" (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert "Revert of https://codereview.chromium.org/129423002/" fixed new api references in unit tests This reverts commit ffc0058e1fbcbd69617e1f41b2dce5b5765ff99e. BUG= Committed: https://code.google.com/p/skia/source/detail?r=13057

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -46 lines)			Patch
M	include/core/SkBitmap.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	include/core/SkImageInfo.h	View	1 chunk	+54 lines, -0 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/core/SkImageFilterUtils.cpp	View	1 chunk	+2 lines, -8 lines	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View	1 chunk	+4 lines, -8 lines	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/image/SkImagePriv.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/image/SkImagePriv.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/image/SkImage_Base.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/image/SkImage_Raster.cpp	View	3 chunks	+7 lines, -10 lines	0 comments	Download
M	src/image/SkSurface_Raster.cpp	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/lazy/SkCachingPixelRef.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/MallocPixelRefTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/PixelRefTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

reed1

Committed patchset #1 manually as r13057 (presubmit successful).

6 years, 11 months ago (2014-01-13 20:28:59 UTC) #1

reed1

6 years, 11 months ago (2014-01-13 20:38:51 UTC) #2

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/134843008/ by reed@google.com.

The reason for reverting is: broken tests.