Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 132643006: Take into account fill-rule for polygon interpolation (Closed)

Created:
6 years, 11 months ago by rwlbuis
Modified:
6 years, 11 months ago
Reviewers:
krit
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), zoltan1, eae+blinkwatch, leviw+renderwatch, dstockwell, Timothy Loh, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Take into account fill-rule for polygon interpolation Implement the polygon fill-rule part of http://dev.w3.org/csswg/css-shapes/#basic-shape-interpolation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165082

Patch Set 1 #

Patch Set 2 : Fix rebase problem #

Patch Set 3 : Fix test expectation #

Patch Set 4 : Rebase against ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
LayoutTests/animations/interpolation/shape-outside.html View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/shape-outside-expected.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/virtual/legacy-animations-engine/animations/interpolation/shape-outside-expected.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/style/BasicShapes.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rwlbuis
Port from https://bugs.webkit.org/show_bug.cgi?id=125508. Thetesting framework is a bit different so I had to change the ...
6 years, 11 months ago (2014-01-13 15:51:29 UTC) #1
krit
lgtm
6 years, 11 months ago (2014-01-14 16:22:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/132643006/180001
6 years, 11 months ago (2014-01-14 16:24:54 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 17:39:22 UTC) #4
Message was sent while issue was closed.
Change committed as 165082

Powered by Google App Engine
This is Rietveld 408576698