Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Issue 132643002: Switch ControlGroup and MatchCompleteDummy to XHR PUT from alert. (Closed)

Created:
6 years, 11 months ago by davidben
Modified:
6 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Switch ControlGroup and MatchCompleteDummy to XHR PUT from alert. If the test exits before the navigation completes, the alert may cause difficulties. Use PUTs instead for an abort which does not trigger UI or anything. Re-enable the tests on OS X as that was probably the cause for the flake. BUG=142535, 142912 TEST=PrerenderBrowserTest.ControlGroup, PrerenderBrowserTest.MatchCompleteDummy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 2 chunks +7 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davidben
Ran into this as part of other test fixup work I'm doing. It occurred to ...
6 years, 11 months ago (2014-01-09 21:47:51 UTC) #1
mmenke
On 2014/01/09 21:47:51, David Benjamin wrote: > Ran into this as part of other test ...
6 years, 11 months ago (2014-01-09 21:51:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/132643002/1
6 years, 11 months ago (2014-01-09 22:41:55 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 05:08:08 UTC) #4
Message was sent while issue was closed.
Change committed as 244095

Powered by Google App Engine
This is Rietveld 408576698